Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2433223002: Indexed DB: Remove experimental delete-returns-count change (Closed)

Created:
4 years, 2 months ago by jsbell
Modified:
4 years, 2 months ago
Reviewers:
dmurph
CC:
chromium-reviews, blink-reviews-w3ctests_chromium.org, tfarina, jam, darin-cc_chromium.org, cmumford, blink-reviews, jsbell+idb_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Indexed DB: Remove experimental delete-returns-count change We implemented an experimental change where IDBObjectStore.delete() yielded the number of records deleted. Standards discussion converged on making this opt-in via an option to the method. Back out the change (and test) until we have further consensus on what the option would be. (This was only enabled with the --experimental-... flag.) BUG=611201, 435727 Committed: https://crrev.com/e0966a9bc1b272bf35987de5d39411b87a90c930 Cr-Commit-Position: refs/heads/master@{#426333}

Patch Set 1 #

Messages

Total messages: 13 (7 generated)
jsbell
dmurph@ - please take a look? The backing store plumbing is great, so left in. ...
4 years, 2 months ago (2016-10-19 18:39:59 UTC) #4
dmurph
lgtm
4 years, 2 months ago (2016-10-19 19:11:49 UTC) #5
dmurph
lgtm
4 years, 2 months ago (2016-10-19 19:11:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2433223002/1
4 years, 2 months ago (2016-10-19 23:07:20 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 23:30:10 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:13:08 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0966a9bc1b272bf35987de5d39411b87a90c930
Cr-Commit-Position: refs/heads/master@{#426333}

Powered by Google App Engine
This is Rietveld 408576698