Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 2433193002: Revert of When parsing cookie expiration times, saturate out of range dates (Closed)

Created:
4 years, 2 months ago by huangs
Modified:
4 years, 2 months ago
Reviewers:
Devlin, eroman, mmenke
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, cbentzel+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of When parsing cookie expiration times, saturate out of range dates (patchset #6 id:100001 of https://chromiumcodereview.appspot.com/2424443002/ ) Reason for revert: The new test CookieUtilTest.ParseCookieExpirationTimeBeyond2038 is failing on "Linux test dbg" bot. Original issue's description: > When parsing cookie expiration times, saturate out of range dates > rather than reject them. > > Roughly this means cookie expiration times prior to 1970 on (non-OSX) > POSIX, or after 2038 on 32-bit (non-OSX) POSIX, will now be interpreted > as either very small or very large base::Time values. > > BUG=649416 TBR=eroman@chromium.org,rdevlin.cronin@chromium.org,mmenke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=649416 Committed: https://crrev.com/1b3ea5872041478fcd1e4fcec182961cd2d6e06d Cr-Commit-Position: refs/heads/master@{#426240}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -225 lines) Patch
M extensions/browser/api/web_request/web_request_api_helpers.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M net/cookies/canonical_cookie.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/cookies/canonical_cookie.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/cookies/cookie_monster_store_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/cookies/cookie_util.h View 1 chunk +2 lines, -13 lines 0 comments Download
M net/cookies/cookie_util.cc View 3 chunks +8 lines, -80 lines 0 comments Download
M net/cookies/cookie_util_unittest.cc View 2 chunks +69 lines, -121 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
huangs
Created Revert of When parsing cookie expiration times, saturate out of range dates
4 years, 2 months ago (2016-10-19 17:49:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2433193002/1
4 years, 2 months ago (2016-10-19 17:49:57 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 17:51:10 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:10:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b3ea5872041478fcd1e4fcec182961cd2d6e06d
Cr-Commit-Position: refs/heads/master@{#426240}

Powered by Google App Engine
This is Rietveld 408576698