Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: google_apis/gcm/engine/registration_request.cc

Issue 2433083003: GCM Registration: rename RESPONSE_PARSING_FAILED to NO_RESPONSE_BODY (Closed)
Patch Set: Fix registration_request.cc ShouldRetryWithStatus Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « google_apis/gcm/engine/registration_request.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/gcm/engine/registration_request.cc
diff --git a/google_apis/gcm/engine/registration_request.cc b/google_apis/gcm/engine/registration_request.cc
index 137b3c26c00326e86f4c05a08921d706ebded186..58ce94b9df012b35da77ea0cb7711b87b960b92f 100644
--- a/google_apis/gcm/engine/registration_request.cc
+++ b/google_apis/gcm/engine/registration_request.cc
@@ -69,7 +69,7 @@ bool ShouldRetryWithStatus(RegistrationRequest::Status status) {
case RegistrationRequest::UNKNOWN_ERROR:
case RegistrationRequest::URL_FETCHING_FAILED:
case RegistrationRequest::HTTP_NOT_OK:
- case RegistrationRequest::RESPONSE_PARSING_FAILED:
+ case RegistrationRequest::NO_RESPONSE_BODY:
return true;
case RegistrationRequest::SUCCESS:
case RegistrationRequest::INVALID_PARAMETERS:
@@ -206,7 +206,7 @@ RegistrationRequest::Status RegistrationRequest::ParseResponse(
std::string response;
if (!source->GetResponseAsString(&response)) {
LOG(ERROR) << "Failed to parse registration response as a string.";
- return RESPONSE_PARSING_FAILED;
+ return NO_RESPONSE_BODY;
}
if (source->GetResponseCode() == net::HTTP_OK) {
« no previous file with comments | « google_apis/gcm/engine/registration_request.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698