Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 2432933006: Create separate archive of Mac packaging tools. (Closed)

Created:
4 years, 2 months ago by Michael Moss
Modified:
4 years, 2 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create separate archive of Mac packaging tools. This is in preparation for separating diff creation from signing, similar to the Windows processing, and needed by the new signing pipeline. R=mark@chromium.org BUG=b/31931170 Committed: https://crrev.com/24666393f4852f5d97b7b94ed750989dbf457e75 Cr-Commit-Position: refs/heads/master@{#426800}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/tools/build/mac/FILES.cfg View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
Michael Moss
4 years, 2 months ago (2016-10-21 00:43:43 UTC) #1
Mark Mentovai
Diff creation needs to consume signed things and also produce signed things. It sounds like ...
4 years, 2 months ago (2016-10-21 03:24:56 UTC) #2
Michael Moss
On 2016/10/21 03:24:56, Mark Mentovai wrote: > Diff creation needs to consume signed things and ...
4 years, 2 months ago (2016-10-21 03:41:48 UTC) #3
Michael Moss
On 2016/10/21 03:41:48, Michael Moss wrote: > On 2016/10/21 03:24:56, Mark Mentovai wrote: > > ...
4 years, 2 months ago (2016-10-21 03:47:39 UTC) #4
Mark Mentovai
Great. LGTM.
4 years, 2 months ago (2016-10-21 10:35:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2432933006/1
4 years, 2 months ago (2016-10-21 15:32:02 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 15:50:02 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/24666393f4852f5d97b7b94ed750989dbf457e75 Cr-Commit-Position: refs/heads/master@{#426800}
4 years, 2 months ago (2016-10-21 16:04:46 UTC) #10
Mark Mentovai
I don’t know what can and can’t happen on the new signing system, but we ...
4 years, 2 months ago (2016-10-21 16:16:33 UTC) #11
Michael Moss
4 years, 2 months ago (2016-10-21 16:24:48 UTC) #12
Message was sent while issue was closed.
On 2016/10/21 16:16:33, Mark Mentovai wrote:
> I don’t know what can and can’t happen on the new signing system, but we may
> need to make it a 4-step, actually.
> 
> 1. Sign inner components (once)
> 2. After sticking the signed inner components into channelized and branded
apps,
> sign each of those apps
> 3. Package the apps up into disk images, and sign the disk images
> 4. Build diffs given new signed disk images and previously-released signed
disk
> images, and then sign those

Those first 3 steps can happen all at once, and is what I referred to as "sign
the full installers". It's just the diffs that need to be separate because that
requires talking to omahaproxy and fetching old builds from cloud storage, but
the new signing system is much more restricted, so can't do those things.

Powered by Google App Engine
This is Rietveld 408576698