Chromium Code Reviews

Issue 2432923002: [builtins] Optimize Number.parseInt for HeapNumbers in Signed32 range. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Optimize Number.parseInt for HeapNumbers in Signed32 range. When the input to Number.parseInt is a HeapNumber in Signed32 range, we can just return the (truncated) input value (i.e. we need to map -0 to 0 due to the ToString conversion). R=jarin@chromium.org Committed: https://crrev.com/efe4fd4b5b831d253a71b564be3786203926e242 Cr-Commit-Position: refs/heads/master@{#40419}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+14 lines, -7 lines)
M src/builtins/builtins-number.cc View 1 chunk +14 lines, -7 lines 0 comments

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-19 05:10:46 UTC) #1
Jarin
lgtm
4 years, 2 months ago (2016-10-19 05:19:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2432923002/1
4 years, 2 months ago (2016-10-19 05:20:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 05:41:08 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:05:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/efe4fd4b5b831d253a71b564be3786203926e242
Cr-Commit-Position: refs/heads/master@{#40419}

Powered by Google App Engine