Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2432883003: Update all non-generic test expectations files for removed tests when updating w3c tests. (Closed)

Created:
4 years, 2 months ago by qyearsley
Modified:
4 years, 2 months ago
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke, foolip
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update all non-generic test expectations files for removed tests when updating w3c tests. This is a follow up to http://crrev.com/2360893002, which made it so that lines in the generic test expectations file (LayoutTests/TestExpectations) are updated when tests are removed or renamed in the upstream repo. It turns out that this should be done for all test expectations files, not just that one. BUG=649010 Committed: https://crrev.com/01bcbb2eecb603397dc60604e4bc42c9582ea136 Cr-Commit-Position: refs/heads/master@{#426509}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py View 4 chunks +15 lines, -12 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
qyearsley
4 years, 2 months ago (2016-10-20 00:38:08 UTC) #2
Dirk Pranke
lgtm
4 years, 2 months ago (2016-10-20 05:31:32 UTC) #3
foolip
lgtm
4 years, 2 months ago (2016-10-20 09:33:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2432883003/1
4 years, 2 months ago (2016-10-20 15:57:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 17:05:19 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:19:21 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01bcbb2eecb603397dc60604e4bc42c9582ea136
Cr-Commit-Position: refs/heads/master@{#426509}

Powered by Google App Engine
This is Rietveld 408576698