Fix ReadableStream getReader({mode: 'byob'})

Fix ReadableStream getReader({mode: 'byob'})

getReader({mode: 'byob'}) failed with a ReferenceError. Make it throw a
TypeError instead.

BUG=657743
Committed: https://crrev.com/4abae818f5a6e89e539c091819f55d113cf2dc46
Cr-Commit-Position: refs/heads/master@{#426453}

[Adam Rice, 2016-10-20 09:29:35]

ricea@chromium.org changed reviewers:
+ tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2016-10-20 10:25:54]

lgtm

[tyoshino (SeeGerritForStatus), 2016-10-20 10:26:01]

lgtm

https://codereview.chromium.org/2432863004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/streams/ReadableStream.js (right):

https://codereview.chromium.org/2432863004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/streams/ReadableStream.js:178: if
(IsReadableStreamDefaultController(this[readableStreamController])) {
i think it's ok not to have this if and just throw now.

[Adam Rice, 2016-10-20 10:35:34]

https://codereview.chromium.org/2432863004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/streams/ReadableStream.js (right):

https://codereview.chromium.org/2432863004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/streams/ReadableStream.js:178: if
(IsReadableStreamDefaultController(this[readableStreamController])) {
On 2016/10/20 10:26:01, tyoshino wrote:
> i think it's ok not to have this if and just throw now.

Done.

[Adam Rice, 2016-10-20 10:36:08]

The CQ bit was checked by ricea@chromium.org

[Adam Rice, 2016-10-20 10:36:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
tyoshino@chromium.org
Link to the patchset: https://codereview.chromium.org/2432863004/#ps40001
(title: "Unconditionally throw if mode is 'byob'")

[commit-bot: I haz the power, 2016-10-20 10:36:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 11:55:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-21 13:17:30]

Description was changed from

==========
Fix ReadableStream getReader({mode: 'byob'})

getReader({mode: 'byob'}) failed with a ReferenceError. Make it throw a
TypeError instead.

BUG=657743
==========

to

==========
Fix ReadableStream getReader({mode: 'byob'})

getReader({mode: 'byob'}) failed with a ReferenceError. Make it throw a
TypeError instead.

BUG=657743

Committed: https://crrev.com/4abae818f5a6e89e539c091819f55d113cf2dc46
Cr-Commit-Position: refs/heads/master@{#426453}
==========

[commit-bot: I haz the power, 2016-10-21 13:17:30]

Patchset 3 (id:??) landed as
https://crrev.com/4abae818f5a6e89e539c091819f55d113cf2dc46
Cr-Commit-Position: refs/heads/master@{#426453}