[ios] Adds a provider API for AudioSessionController.

[ios] Adds a provider API for AudioSessionController.

Creates VoiceSearchProvider to act as a namespace for provider APIs related to
voice search.

Also adds TestAudioSessionController and TestVoiceSearchProvider for use in
unittests.

BUG=656617
TEST=No visible (or audible) impact.

Committed: https://crrev.com/9cf76a0b0de2b5e5f2cc80a3df5a0e7a309b4cef
Cr-Commit-Position: refs/heads/master@{#426170}

[rohitrao (ping after 24h), 2016-10-18 21:03:58]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 21:04:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rohitrao (ping after 24h), 2016-10-18 21:06:15]

rohitrao@chromium.org changed reviewers:
+ sdefresne@chromium.org

[rohitrao (ping after 24h), 2016-10-18 21:06:16]

Should VoiceSearchProvider be in the ios namespace, to match all the other
providers?

[sdefresne, 2016-10-18 22:19:44]

lgtm with nits

https://codereview.chromium.org/2432563002/diff/1/ios/chrome/browser/voice/BU...
File ios/chrome/browser/voice/BUILD.gn (right):

https://codereview.chromium.org/2432563002/diff/1/ios/chrome/browser/voice/BU...
ios/chrome/browser/voice/BUILD.gn:31: ":voice",
Need a dependency on //base here.

https://codereview.chromium.org/2432563002/diff/1/ios/public/provider/chrome/...
File ios/public/provider/chrome/browser/chrome_browser_provider.h (right):

https://codereview.chromium.org/2432563002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/chrome_browser_provider.h:149: virtual
VoiceSearchProvider* GetVoiceSearchProvider();
This method should be const.

https://codereview.chromium.org/2432563002/diff/1/ios/public/provider/chrome/...
File ios/public/provider/chrome/browser/test_chrome_browser_provider.h (right):

https://codereview.chromium.org/2432563002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/test_chrome_browser_provider.h:17: class
TestVoiceSearchProvider;
Remove.

https://codereview.chromium.org/2432563002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/test_chrome_browser_provider.h:41:
std::unique_ptr<TestVoiceSearchProvider> test_voice_search_provider_;
Use VoiceSearchProvider here too:

  std::unique_ptr<VoiceSearchProvider> voice_search_provider_;

BTW, can you also do this for TestUpdatableResourceProvider too?

https://codereview.chromium.org/2432563002/diff/1/ios/public/provider/chrome/...
File ios/public/provider/chrome/browser/test_chrome_browser_provider.mm (right):

https://codereview.chromium.org/2432563002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/test_chrome_browser_provider.mm:31: :
test_updatable_resource_provider_(new TestUpdatableResourceProvider),
nit: can you change this to use base::MakeUnique<> here too?

https://codereview.chromium.org/2432563002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/test_chrome_browser_provider.mm:67:
base::scoped_nsobject<VoiceSearchLanguage> en([[VoiceSearchLanguage alloc]
nit: can you change to the following:

  return voice_search_provider_->GetAvailableVoiceSearchLanguages();

https://codereview.chromium.org/2432563002/diff/1/ios/public/provider/chrome/...
File ios/public/provider/chrome/browser/voice/voice_search_provider.mm (right):

https://codereview.chromium.org/2432563002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/voice/voice_search_provider.mm:10: return
[NSArray array];
nit:

    return @[];

[commit-bot: I haz the power, 2016-10-18 22:52:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 22:52:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rohitrao (ping after 24h), 2016-10-18 23:30:44]

Updated to no longer use the ios namespace, because it's cheap to make this
change now.

https://codereview.chromium.org/2432563002/diff/1/ios/chrome/browser/voice/BU...
File ios/chrome/browser/voice/BUILD.gn (right):

https://codereview.chromium.org/2432563002/diff/1/ios/chrome/browser/voice/BU...
ios/chrome/browser/voice/BUILD.gn:31: ":voice",
On 2016/10/18 22:19:43, sdefresne wrote:
> Need a dependency on //base here.

Done.

https://codereview.chromium.org/2432563002/diff/1/ios/public/provider/chrome/...
File ios/public/provider/chrome/browser/chrome_browser_provider.h (right):

https://codereview.chromium.org/2432563002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/chrome_browser_provider.h:149: virtual
VoiceSearchProvider* GetVoiceSearchProvider();
On 2016/10/18 22:19:43, sdefresne wrote:
> This method should be const.

Done.

https://codereview.chromium.org/2432563002/diff/1/ios/public/provider/chrome/...
File ios/public/provider/chrome/browser/test_chrome_browser_provider.h (right):

https://codereview.chromium.org/2432563002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/test_chrome_browser_provider.h:17: class
TestVoiceSearchProvider;
On 2016/10/18 22:19:44, sdefresne wrote:
> Remove.

Done.

https://codereview.chromium.org/2432563002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/test_chrome_browser_provider.h:41:
std::unique_ptr<TestVoiceSearchProvider> test_voice_search_provider_;
On 2016/10/18 22:19:44, sdefresne wrote:
> Use VoiceSearchProvider here too:
> 
>   std::unique_ptr<VoiceSearchProvider> voice_search_provider_;
> 
> BTW, can you also do this for TestUpdatableResourceProvider too?

Done.

https://codereview.chromium.org/2432563002/diff/1/ios/public/provider/chrome/...
File ios/public/provider/chrome/browser/test_chrome_browser_provider.mm (right):

https://codereview.chromium.org/2432563002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/test_chrome_browser_provider.mm:31: :
test_updatable_resource_provider_(new TestUpdatableResourceProvider),
On 2016/10/18 22:19:44, sdefresne wrote:
> nit: can you change this to use base::MakeUnique<> here too?

Done.

https://codereview.chromium.org/2432563002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/test_chrome_browser_provider.mm:67:
base::scoped_nsobject<VoiceSearchLanguage> en([[VoiceSearchLanguage alloc]
On 2016/10/18 22:19:44, sdefresne wrote:
> nit: can you change to the following:
> 
>   return voice_search_provider_->GetAvailableVoiceSearchLanguages();

Done.

https://codereview.chromium.org/2432563002/diff/1/ios/public/provider/chrome/...
File ios/public/provider/chrome/browser/voice/voice_search_provider.h (right):

https://codereview.chromium.org/2432563002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/voice/voice_search_provider.h:24: virtual
NSArray* GetAvailableVoiceSearchLanguages() const;
Renamed to GetAvailableLanguages(), because the "VoiceSearch" part seemed
redundant.

https://codereview.chromium.org/2432563002/diff/1/ios/public/provider/chrome/...
File ios/public/provider/chrome/browser/voice/voice_search_provider.mm (right):

https://codereview.chromium.org/2432563002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/voice/voice_search_provider.mm:10: return
[NSArray array];
On 2016/10/18 22:19:44, sdefresne wrote:
> nit:
> 
>     return @[];

Done.

[rohitrao (ping after 24h), 2016-10-18 23:31:36]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 23:32:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-10-18 23:43:49]

lgtm

https://codereview.chromium.org/2432563002/diff/20001/ios/chrome/browser/voic...
File ios/chrome/browser/voice/test_audio_session_controller.cc (right):

https://codereview.chromium.org/2432563002/diff/20001/ios/chrome/browser/voic...
ios/chrome/browser/voice/test_audio_session_controller.cc:7: #include
"base/logging.h"
Remove

https://codereview.chromium.org/2432563002/diff/20001/ios/public/provider/chr...
File ios/public/provider/chrome/browser/voice/test_voice_search_provider.mm
(right):

https://codereview.chromium.org/2432563002/diff/20001/ios/public/provider/chr...
ios/public/provider/chrome/browser/voice/test_voice_search_provider.mm:8:
#include "base/memory/ptr_util.h"
Remove

[rohitrao (ping after 24h), 2016-10-19 00:21:20]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 00:21:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 00:30:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 00:30:49]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[rohitrao (ping after 24h), 2016-10-19 11:12:20]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 11:13:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 11:59:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 11:59:40]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rohitrao (ping after 24h), 2016-10-19 12:19:22]

Moved all the files into the provider directory, because that's where they
really belong.

https://codereview.chromium.org/2432563002/diff/20001/ios/chrome/browser/voic...
File ios/chrome/browser/voice/test_audio_session_controller.cc (right):

https://codereview.chromium.org/2432563002/diff/20001/ios/chrome/browser/voic...
ios/chrome/browser/voice/test_audio_session_controller.cc:7: #include
"base/logging.h"
On 2016/10/18 23:43:48, sdefresne wrote:
> Remove

Done.

https://codereview.chromium.org/2432563002/diff/20001/ios/public/provider/chr...
File ios/public/provider/chrome/browser/voice/test_voice_search_provider.mm
(right):

https://codereview.chromium.org/2432563002/diff/20001/ios/public/provider/chr...
ios/public/provider/chrome/browser/voice/test_voice_search_provider.mm:8:
#include "base/memory/ptr_util.h"
On 2016/10/18 23:43:48, sdefresne wrote:
> Remove

Done.

[rohitrao (ping after 24h), 2016-10-19 12:19:31]

The CQ bit was checked by rohitrao@chromium.org

[rohitrao (ping after 24h), 2016-10-19 12:19:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2432563002/#ps80001
(title: "Rebased.")

[commit-bot: I haz the power, 2016-10-19 12:19:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-10-19 12:54:26]

lgtm

[commit-bot: I haz the power, 2016-10-19 13:15:48]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-21 13:07:42]

Description was changed from

==========
[ios] Adds a provider API for AudioSessionController.

Creates VoiceSearchProvider to act as a namespace for provider APIs related to
voice search.

Also adds TestAudioSessionController and TestVoiceSearchProvider for use in
unittests.

BUG=656617
TEST=No visible (or audible) impact.
==========

to

==========
[ios] Adds a provider API for AudioSessionController.

Creates VoiceSearchProvider to act as a namespace for provider APIs related to
voice search.

Also adds TestAudioSessionController and TestVoiceSearchProvider for use in
unittests.

BUG=656617
TEST=No visible (or audible) impact.

Committed: https://crrev.com/9cf76a0b0de2b5e5f2cc80a3df5a0e7a309b4cef
Cr-Commit-Position: refs/heads/master@{#426170}
==========

[commit-bot: I haz the power, 2016-10-21 13:07:42]

Patchset 5 (id:??) landed as
https://crrev.com/9cf76a0b0de2b5e5f2cc80a3df5a0e7a309b4cef
Cr-Commit-Position: refs/heads/master@{#426170}