[MD settings] help button in content settings site lists

[MD settings] help button in content settings site lists

This CL removes the Learn more row button in the Content settings and
puts that functionality in a new help button in the upper right of the
subpage.

BUG=658060
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/5805da7f9fe4258aa8c2f39c1454e72a6ff57c63
Cr-Commit-Position: refs/heads/master@{#426941}

[dschuyler, 2016-10-20 23:18:43]

Description was changed from

==========
[MD settings] help button in content settings site lists

This CL removes the Learn more row button in the Content settings and
puts that functionality in a new help button in the upper right of the
subpage.

BUG=658060
==========

to

==========
[MD settings] help button in content settings site lists

This CL removes the Learn more row button in the Content settings and
puts that functionality in a new help button in the upper right of the
subpage.

BUG=658060
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-10-20 23:18:45]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 23:19:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-10-20 23:27:45]

dschuyler@chromium.org changed reviewers:
+ dpapad@chromium.org

[dschuyler, 2016-10-20 23:27:46]

https://codereview.chromium.org/2432383005/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/privacy_page/privacy_page.html (right):

https://codereview.chromium.org/2432383005/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/privacy_page/privacy_page.html:190:
is="paper-icon-button-light" on-tap="onHelpTap_"></button>
dpapad@ and I discussed a few ways this button could be added.
None of the options seemed amazing, so I chose one. This has 
the downside of repeating several times in this file, but imo
the other options were slightly less good.

https://codereview.chromium.org/2432383005/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/privacy_page/privacy_page.js (right):

https://codereview.chromium.org/2432383005/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/privacy_page/privacy_page.js:102: },
This is moved from site_settings_category.js

[commit-bot: I haz the power, 2016-10-21 01:29:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 01:29:04]

Dry run: This issue passed the CQ dry run.

[dpapad, 2016-10-21 01:53:59]

https://codereview.chromium.org/2432383005/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page/settings_subpage.html
(right):

https://codereview.chromium.org/2432383005/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/settings_subpage.html:55:
<content></content>
Mostly curious: How does this work with relation to the previous content tag?
Does it match everything that has not been matched already? Should there be
something like "not .subpage-title-extra" here?

https://codereview.chromium.org/2432383005/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_shared_css.html (right):

https://codereview.chromium.org/2432383005/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_shared_css.html:31:
button[is="paper-icon-button-light"].icon-help {
Double quotes are used here, no quotes and single quotes are used at line 35
below. Can we stick with one way? From the styleguide

"Use single quotation marks for attribute selectors and property values", see
https://google.github.io/styleguide/htmlcssguide.xml?showone=CSS_Quotation_Ma....


Also, since this is only used in the privacy page, why not put this CSS rule
there?

[dschuyler, 2016-10-21 19:37:47]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 19:38:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-10-21 21:09:34]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[dschuyler, 2016-10-21 21:10:01]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-10-21 21:10:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-10-21 21:10:41]

https://codereview.chromium.org/2432383005/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page/settings_subpage.html
(right):

https://codereview.chromium.org/2432383005/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/settings_subpage.html:55:
<content></content>
On 2016/10/21 01:53:59, dpapad wrote:
> Mostly curious: How does this work with relation to the previous content tag?
> Does it match everything that has not been matched already? Should there be
> something like "not .subpage-title-extra" here?

The selected branch of the tree is moved from A to B, so it's
no longer in the original place.

https://codereview.chromium.org/2432383005/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_shared_css.html (right):

https://codereview.chromium.org/2432383005/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_shared_css.html:31:
button[is="paper-icon-button-light"].icon-help {
On 2016/10/21 01:53:59, dpapad wrote:
> Double quotes are used here, no quotes and single quotes are used at line 35
> below. Can we stick with one way? From the styleguide
> 
> "Use single quotation marks for attribute selectors and property values", see
>
https://google.github.io/styleguide/htmlcssguide.xml?showone=CSS_Quotation_Ma....
> 
> 
> Also, since this is only used in the privacy page, why not put this CSS rule
> there?

I need to make a presubmit for this. In my mind, I want it to match
what I see in the html, so I keep making this mistake.

Done.

[dpapad, 2016-10-21 21:38:05]

lgtm

[commit-bot: I haz the power, 2016-10-21 23:33:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 23:33:10]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2016-10-22 00:51:28]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2016-10-22 00:51:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-22 01:16:28]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-10-22 01:19:36]

Description was changed from

==========
[MD settings] help button in content settings site lists

This CL removes the Learn more row button in the Content settings and
puts that functionality in a new help button in the upper right of the
subpage.

BUG=658060
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] help button in content settings site lists

This CL removes the Learn more row button in the Content settings and
puts that functionality in a new help button in the upper right of the
subpage.

BUG=658060
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/5805da7f9fe4258aa8c2f39c1454e72a6ff57c63
Cr-Commit-Position: refs/heads/master@{#426941}
==========

[commit-bot: I haz the power, 2016-10-22 01:19:37]

Patchset 2 (id:??) landed as
https://crrev.com/5805da7f9fe4258aa8c2f39c1454e72a6ff57c63
Cr-Commit-Position: refs/heads/master@{#426941}