Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2432373004: Revert of [profiler] Update cpu profile tracing format. (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 1 month ago
Reviewers:
caseq, lpy, alph, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [profiler] Update cpu profile tracing format. (patchset #2 id:20001 of https://chromiumcodereview.appspot.com/2425093002/ ) Reason for revert: Breaks https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/10805 See also: https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > [profiler] Update cpu profile tracing format. > > Encapsulate nodes and samples into cpuProfile object. > > BUG=chromium:406277 TBR=caseq@chromium.org,lpy@chromium.org,yangguo@chromium.org,alph@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:406277 Committed: https://crrev.com/b659cc1e81d4ed380733d10756c8267fb1637820 Cr-Commit-Position: refs/heads/master@{#40452}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -25 lines) Patch
M src/profiler/profile-generator.cc View 4 chunks +20 lines, -23 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [profiler] Update cpu profile tracing format.
4 years, 2 months ago (2016-10-20 07:38:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2432373004/1
4 years, 2 months ago (2016-10-20 07:38:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 07:40:08 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:07:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b659cc1e81d4ed380733d10756c8267fb1637820
Cr-Commit-Position: refs/heads/master@{#40452}

Powered by Google App Engine
This is Rietveld 408576698