Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2432373003: Follow up: stop mirroring session when tab is closed. (Closed)

Created:
4 years, 2 months ago by xjz
Modified:
4 years, 2 months ago
Reviewers:
miu
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Follow up: stop mirroring session when tab is closed. Rename the callback function and clarify the logic to prevent same bug happen again in future. BUG=655240 Committed: https://crrev.com/7be1ce80e3dbf1f42a0c6568d5d894b508e47af7 Cr-Commit-Position: refs/heads/master@{#426327}

Patch Set 1 #

Patch Set 2 : Fix unittests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M content/renderer/media/media_stream_video_capturer_source.h View 1 chunk +6 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_video_capturer_source.cc View 2 chunks +14 lines, -7 lines 0 comments Download
M content/renderer/media/media_stream_video_capturer_source_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
xjz
PTAL
4 years, 2 months ago (2016-10-19 18:12:40 UTC) #4
miu
lgtm! Thanks for the follow-up. It will help eliminate the same confusion for the next ...
4 years, 2 months ago (2016-10-19 22:53:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2432373003/20001
4 years, 2 months ago (2016-10-19 22:56:16 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-19 23:18:59 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:12:56 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7be1ce80e3dbf1f42a0c6568d5d894b508e47af7
Cr-Commit-Position: refs/heads/master@{#426327}

Powered by Google App Engine
This is Rietveld 408576698