Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 2432213002: Update external protocol handler strings to use "can't" instead of "cannot". (Closed)

Created:
4 years, 2 months ago by dominickn
Modified:
4 years, 2 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update external protocol handler strings to use "can't" instead of "cannot". UI Review has requested that these strings use the contraction. BUG=656830 Committed: https://crrev.com/de099fab98c35f5a8ee91bdbde33b4065b944e6b Cr-Commit-Position: refs/heads/master@{#426294}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/chromium_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
dominickn
PTAL, thanks!
4 years, 2 months ago (2016-10-19 04:58:59 UTC) #4
Matt Giuca
lgtm
4 years, 2 months ago (2016-10-19 05:39:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2432213002/1
4 years, 2 months ago (2016-10-19 21:08:21 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 21:48:05 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:11:50 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de099fab98c35f5a8ee91bdbde33b4065b944e6b
Cr-Commit-Position: refs/heads/master@{#426294}

Powered by Google App Engine
This is Rietveld 408576698