Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2432173006: [Blink, RemotePlayback] Handle disabling remote playback (Closed)

Created:
4 years, 2 months ago by whywhat
Modified:
4 years, 2 months ago
CC:
blink-reviews, chromium-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Blink, RemotePlayback] Handle disabling remote playback Notifies RemotePlayback about the attribute being set that rejects the pending prompt() promise and cancels all availability watch callbacks. BUG=657566 TEST=RemotePlaybackTest Committed: https://crrev.com/abdffaa22fbf5d88087a1c5f6dfbfdb41e67d301 Cr-Commit-Position: refs/heads/master@{#426516}

Patch Set 1 #

Patch Set 2 : Added UserGesture to unittests #

Patch Set 3 : Fixed the static method calls #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -3 lines) Patch
M third_party/WebKit/Source/modules/remoteplayback/HTMLMediaElementRemotePlayback.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/remoteplayback/HTMLMediaElementRemotePlayback.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackTest.cpp View 1 2 6 chunks +66 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
whywhat
PTaL
4 years, 2 months ago (2016-10-19 21:15:50 UTC) #2
mlamouri (slow - plz ping)
lgtm
4 years, 2 months ago (2016-10-19 21:59:14 UTC) #5
whywhat
Added UserGesture to unittests
4 years, 2 months ago (2016-10-20 03:23:07 UTC) #8
whywhat
Fixed the static method calls
4 years, 2 months ago (2016-10-20 15:35:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2432173006/40001
4 years, 2 months ago (2016-10-20 15:36:23 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-20 17:18:44 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:19:35 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/abdffaa22fbf5d88087a1c5f6dfbfdb41e67d301
Cr-Commit-Position: refs/heads/master@{#426516}

Powered by Google App Engine
This is Rietveld 408576698