Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.h

Issue 2432173005: Get rid of VisibleSelection::selectionFromContentsOfNode() (Closed)
Patch Set: 2016-10-20T17:14:18 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleSelection.h
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.h b/third_party/WebKit/Source/core/editing/VisibleSelection.h
index 227f0d14b3edcdfd47c010109e5ad82f7176b12a..25bf5e07ef875b069b6163ef04997020aa7f5d0a 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelection.h
+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.h
@@ -59,14 +59,9 @@ class CORE_TEMPLATE_CLASS_EXPORT VisibleSelectionTemplate {
VisibleSelectionTemplate(const VisibleSelectionTemplate&);
VisibleSelectionTemplate& operator=(const VisibleSelectionTemplate&);
- // Note: |create()| should be used only by |createVisibleSelection| and
- // |selectionFromContentsOfNode|.
+ // Note: |create()| should be used only by |createVisibleSelection|.
static VisibleSelectionTemplate create(const SelectionTemplate<Strategy>&);
- // TODO(editing-dev): We should get rid of this function and instead, use
- // EphemeralRangeTemplate::rangeOfContents and SelectionTemplate::Builder.
- static VisibleSelectionTemplate selectionFromContentsOfNode(Node*);
-
SelectionType getSelectionType() const { return m_selectionType; }
void setAffinity(TextAffinity affinity) { m_affinity = affinity; }

Powered by Google App Engine
This is Rietveld 408576698