Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2432163005: [wrapper-tracing] Adjust expectations for sources-search-scope-in-files.html (Closed)

Created:
4 years, 2 months ago by Michael Lippautz
Modified:
4 years, 2 months ago
Reviewers:
haraken, Marcel Hlopko
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[wrapper-tracing] Adjust expectations for sources-search-scope-in-files.html The inspector now finds one additional script location in the test which was already collected using object grouping. BUG=chromium:468240 R=haraken@chromium.org,hlopko@chromium.org NOTRY=true Committed: https://crrev.com/40b310d930949bf0c7c830d81cf01481830c40b4 Cr-Commit-Position: refs/heads/master@{#426526}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
A + third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=TraceWrappables/http/tests/inspector/search/sources-search-scope-in-files-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Michael Lippautz
4 years, 2 months ago (2016-10-20 17:35:48 UTC) #2
haraken
Add more explanation to the CL description. LGTM
4 years, 2 months ago (2016-10-20 17:37:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2432163005/1
4 years, 2 months ago (2016-10-20 17:40:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 17:56:22 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:20:03 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/40b310d930949bf0c7c830d81cf01481830c40b4
Cr-Commit-Position: refs/heads/master@{#426526}

Powered by Google App Engine
This is Rietveld 408576698