Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: third_party/WebKit/Source/core/css/MediaQueryEvaluator.h

Issue 2432153005: Always evaluate media features to true without MediaValues. (Closed)
Patch Set: DCHECK(view). Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/MediaQueryEvaluator.h
diff --git a/third_party/WebKit/Source/core/css/MediaQueryEvaluator.h b/third_party/WebKit/Source/core/css/MediaQueryEvaluator.h
index dd8236997b5c591b4c2378951fcf43233e8ffd93..56588f3fc0d338a3c6813beacfdd1809d63cbdf6 100644
--- a/third_party/WebKit/Source/core/css/MediaQueryEvaluator.h
+++ b/third_party/WebKit/Source/core/css/MediaQueryEvaluator.h
@@ -61,18 +61,13 @@ class CORE_EXPORT MediaQueryEvaluator final
public:
static void init();
- // Creates evaluator which evaluates only simple media queries
- // Evaluator returns true for "all", and returns value of \mediaFeatureResult
- // for any media features.
-
- explicit MediaQueryEvaluator(bool mediaFeatureResult = false);
+ // Creates evaluator which evaluates to true for all media queries.
+ MediaQueryEvaluator() {}
// Creates evaluator which evaluates only simple media queries
- // Evaluator returns true for acceptedMediaType and returns value of
- // \mediafeatureResult for any media features.
-
- MediaQueryEvaluator(const char* acceptedMediaType,
- bool mediaFeatureResult = false);
+ // Evaluator returns true for acceptedMediaType and returns true for any media
+ // features.
+ MediaQueryEvaluator(const char* acceptedMediaType);
// Creates evaluator which evaluates full media queries.
explicit MediaQueryEvaluator(LocalFrame*);
@@ -106,7 +101,6 @@ class CORE_EXPORT MediaQueryEvaluator final
const String mediaType() const;
String m_mediaType;
- bool m_expectedResult = false;
Member<MediaValues> m_mediaValues;
};
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698