Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1551)

Issue 2432143002: [turbofan] Fix invalid Number.parseInt inlining. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix invalid Number.parseInt inlining. The inlined version of Number.parseInt did a ToInt32 truncation, which is not what the EcmaScript specification says. R=jarin@chromium.org BUG=v8:5538 Committed: https://crrev.com/3a7eac15e8ab22f6e76be7011578ef855d9b6413 Cr-Commit-Position: refs/heads/master@{#40418}

Patch Set 1 #

Patch Set 2 : Fix unittests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -7 lines) Patch
M src/compiler/js-builtin-reducer.cc View 1 chunk +4 lines, -5 lines 0 comments Download
A test/mjsunit/compiler/regress-5538.js View 1 chunk +53 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-19 04:16:31 UTC) #1
Jarin
lgtm
4 years, 2 months ago (2016-10-19 04:20:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2432143002/1
4 years, 2 months ago (2016-10-19 04:20:55 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/10759) v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 2 months ago (2016-10-19 04:35:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2432143002/20001
4 years, 2 months ago (2016-10-19 04:40:56 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-19 05:17:38 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:05:37 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3a7eac15e8ab22f6e76be7011578ef855d9b6413
Cr-Commit-Position: refs/heads/master@{#40418}

Powered by Google App Engine
This is Rietveld 408576698