Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2432043006: [turbofan] Remove dead state value validation. (Closed)

Created:
4 years, 2 months ago by Michael Starzinger
Modified:
4 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove dead state value validation. This removes validation code for state value consistency within frame states in the {BytecodeGraphBuilder} that is no longer used. R=jarin@chromium.org Committed: https://crrev.com/e75d6885cd04ab5364886b8037aa5aab438b7833 Cr-Commit-Position: refs/heads/master@{#40461}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -50 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 3 chunks +0 lines, -50 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
4 years, 2 months ago (2016-10-20 09:34:13 UTC) #3
Jarin
lgtm. thanks!
4 years, 2 months ago (2016-10-20 09:51:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2432043006/1
4 years, 2 months ago (2016-10-20 10:49:51 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 10:54:09 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:07:46 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e75d6885cd04ab5364886b8037aa5aab438b7833
Cr-Commit-Position: refs/heads/master@{#40461}

Powered by Google App Engine
This is Rietveld 408576698