Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2431833002: customtabs: Re-Create a spare renderer on Tab close. (Closed)

Created:
4 years, 2 months ago by Benoit L
Modified:
4 years, 2 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

customtabs: Re-Create a spare renderer on Tab close. In a lot of cases, several Custom Tabs are created in a sequence, without the embedding application calling warmup() in between launches. This means that spare renderer is only available the first time. This changes re-creates a spare renderer once the Custom Tab is closed. BUG=617214 Committed: https://crrev.com/5238f251742c55de3d5d52aa1aa2a5513ba739e2 Cr-Commit-Position: refs/heads/master@{#426552}

Patch Set 1 #

Patch Set 2 : Make FindBugs happy. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java View 5 chunks +21 lines, -5 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java View 1 2 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Benoit L
4 years, 2 months ago (2016-10-18 21:11:35 UTC) #2
Yusuf
lgtm
4 years, 2 months ago (2016-10-19 18:10:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431833002/1
4 years, 2 months ago (2016-10-19 18:39:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/149190)
4 years, 2 months ago (2016-10-19 21:09:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431833002/20001
4 years, 2 months ago (2016-10-20 18:21:13 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-20 19:01:25 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:20:59 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5238f251742c55de3d5d52aa1aa2a5513ba739e2
Cr-Commit-Position: refs/heads/master@{#426552}

Powered by Google App Engine
This is Rietveld 408576698