Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2431793003: [promises] move PromiseResolveThenableJob debugging code to runtime function (Closed)

Created:
4 years, 2 months ago by gsathya
Modified:
4 years, 1 month ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[promises] move PromiseResolveThenableJob debugging code to runtime function Moving the rest of the debugging code is blocked on making IsPromise inlinable. BUG=v8:5343 Committed: https://crrev.com/cade0f4ba5d4d35aeaddafd61f6d4ab92e64d813 Cr-Commit-Position: refs/heads/master@{#40440}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -13 lines) Patch
M src/heap-symbols.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/js/promise.js View 1 chunk +3 lines, -9 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +14 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
gsathya
the rest of the debugging code is blocked on making IsPromise inlinable
4 years, 2 months ago (2016-10-18 21:22:42 UTC) #4
Dan Ehrenberg
lgtm
4 years, 2 months ago (2016-10-19 14:02:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431793003/1
4 years, 2 months ago (2016-10-19 14:06:37 UTC) #9
adamk
Just a note that your CL description could use the info you've included on this ...
4 years, 2 months ago (2016-10-19 14:11:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431793003/1
4 years, 2 months ago (2016-10-19 14:13:38 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 14:15:09 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:06:45 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cade0f4ba5d4d35aeaddafd61f6d4ab92e64d813
Cr-Commit-Position: refs/heads/master@{#40440}

Powered by Google App Engine
This is Rietveld 408576698