Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

Issue 2431773002: DevTools: Make Timeline navigation keyboard layout agnostic (WASD/ZQSD) (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « AUTHORS ('k') | third_party/WebKit/Source/devtools/front_end/ui_lazy/ChartViewport.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 715 matching lines...) Expand 10 before | Expand all | Expand 10 after
726 */ 726 */
727 function encloseWithTag(tagName, contents) 727 function encloseWithTag(tagName, contents)
728 { 728 {
729 var e = createElement(tagName); 729 var e = createElement(tagName);
730 e.textContent = contents; 730 e.textContent = contents;
731 return e; 731 return e;
732 } 732 }
733 733
734 var recordNode = encloseWithTag("b", WebInspector.shortcutRegistry.short cutDescriptorsForAction("timeline.toggle-recording")[0].name); 734 var recordNode = encloseWithTag("b", WebInspector.shortcutRegistry.short cutDescriptorsForAction("timeline.toggle-recording")[0].name);
735 var reloadNode = encloseWithTag("b", WebInspector.shortcutRegistry.short cutDescriptorsForAction("main.reload")[0].name); 735 var reloadNode = encloseWithTag("b", WebInspector.shortcutRegistry.short cutDescriptorsForAction("main.reload")[0].name);
736 var navigateNode = encloseWithTag("b", WebInspector.UIString("WASD")); 736 var navigateNode = encloseWithTag("b", WebInspector.UIString("WASD (ZQSD )"));
737 var hintText = createElementWithClass("div"); 737 var hintText = createElementWithClass("div");
738 hintText.appendChild(WebInspector.formatLocalized("To capture a new time line, click the record toolbar button or hit %s.", [recordNode])); 738 hintText.appendChild(WebInspector.formatLocalized("To capture a new time line, click the record toolbar button or hit %s.", [recordNode]));
739 hintText.createChild("br"); 739 hintText.createChild("br");
740 hintText.appendChild(WebInspector.formatLocalized("To evaluate page load performance, hit %s to record the reload.", [reloadNode])); 740 hintText.appendChild(WebInspector.formatLocalized("To evaluate page load performance, hit %s to record the reload.", [reloadNode]));
741 hintText.createChild("p"); 741 hintText.createChild("p");
742 hintText.appendChild(WebInspector.formatLocalized("After recording, sele ct an area of interest in the overview by dragging.", [])); 742 hintText.appendChild(WebInspector.formatLocalized("After recording, sele ct an area of interest in the overview by dragging.", []));
743 hintText.createChild("br"); 743 hintText.createChild("br");
744 hintText.appendChild(WebInspector.formatLocalized("Then, zoom and pan th e timeline with the mousewheel and %s keys.", [navigateNode])); 744 hintText.appendChild(WebInspector.formatLocalized("Then, zoom and pan th e timeline with the mousewheel and %s keys.", [navigateNode]));
745 this._hideRecordingHelpMessage(); 745 this._hideRecordingHelpMessage();
746 this._helpMessageElement = this._searchableView.element.createChild("div ", "full-widget-dimmed-banner timeline-status-pane"); 746 this._helpMessageElement = this._searchableView.element.createChild("div ", "full-widget-dimmed-banner timeline-status-pane");
(...skipping 1365 matching lines...) Expand 10 before | Expand all | Expand 10 after
2112 _onKeyDown: function(event) 2112 _onKeyDown: function(event)
2113 { 2113 {
2114 if (event.keyCode === WebInspector.KeyboardShortcut.Keys.Enter.code) { 2114 if (event.keyCode === WebInspector.KeyboardShortcut.Keys.Enter.code) {
2115 event.preventDefault(); 2115 event.preventDefault();
2116 this._apply(); 2116 this._apply();
2117 } 2117 }
2118 }, 2118 },
2119 2119
2120 __proto__: WebInspector.HBox.prototype 2120 __proto__: WebInspector.HBox.prototype
2121 } 2121 }
OLDNEW
« no previous file with comments | « AUTHORS ('k') | third_party/WebKit/Source/devtools/front_end/ui_lazy/ChartViewport.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698