Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2431743002: Ntp: rename group to child now that no classes are named that way anymore. (Closed)

Created:
4 years, 2 months ago by Michael van Ouwerkerk
Modified:
4 years, 2 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ntp: rename group to child now that no classes are named that way anymore. BUG=616090 Committed: https://crrev.com/225f8d7c8ededfdf0508846767515aa0fbf25720 Cr-Commit-Position: refs/heads/master@{#426162}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Delete misleading sentence. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -89 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java View 1 12 chunks +28 lines, -29 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java View 13 chunks +60 lines, -60 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
Michael van Ouwerkerk
Bernhard, could you take a look please?
4 years, 2 months ago (2016-10-18 16:33:05 UTC) #4
Bernhard Bauer
LGTM Argh, that's going to conflict with https://codereview.chromium.org/2430743002/ :) https://codereview.chromium.org/2431743002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java (right): https://codereview.chromium.org/2431743002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java#newcode54 chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java:54: ...
4 years, 2 months ago (2016-10-18 17:04:30 UTC) #7
Michael van Ouwerkerk
https://codereview.chromium.org/2431743002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java (right): https://codereview.chromium.org/2431743002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java#newcode54 chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java:54: * List of all child nodes (which can themselves ...
4 years, 2 months ago (2016-10-19 09:21:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431743002/20001
4 years, 2 months ago (2016-10-19 09:31:44 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years, 2 months ago (2016-10-19 11:53:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431743002/20001
4 years, 2 months ago (2016-10-19 12:27:11 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-19 12:47:49 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:07:27 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/225f8d7c8ededfdf0508846767515aa0fbf25720
Cr-Commit-Position: refs/heads/master@{#426162}

Powered by Google App Engine
This is Rietveld 408576698