Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 2431693002: [turbofan] Remove representation changes for machine constants. (Closed)

Created:
4 years, 2 months ago by Jarin
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove representation changes for machine constants. No machine constants should reach the representation selector. Committed: https://crrev.com/7296bd4980c198aa205347fa20c16121258929b4 Cr-Commit-Position: refs/heads/master@{#40430}

Patch Set 1 #

Patch Set 2 : Fix formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -307 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/representation-change.cc View 1 5 chunks +12 lines, -55 lines 0 comments Download
M test/cctest/compiler/test-representation-change.cc View 1 3 chunks +76 lines, -251 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
Jarin
Could you take a look, please?
4 years, 2 months ago (2016-10-19 04:19:29 UTC) #6
Benedikt Meurer
Awesome! LGTM!1!!
4 years, 2 months ago (2016-10-19 04:41:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431693002/1
4 years, 2 months ago (2016-10-19 05:13:36 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/26801)
4 years, 2 months ago (2016-10-19 05:31:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431693002/20001
4 years, 2 months ago (2016-10-19 11:18:01 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-19 12:05:24 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:06:18 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7296bd4980c198aa205347fa20c16121258929b4
Cr-Commit-Position: refs/heads/master@{#40430}

Powered by Google App Engine
This is Rietveld 408576698