Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: third_party/WebKit/Source/core/css/MediaValuesInitialViewportTest.cpp

Issue 2431613002: Initial viewport is not the same as FrameView rect. (Closed)
Patch Set: DCHECK that initial viewport size is read from main frame only. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/css/MediaValuesInitialViewport.h" 5 #include "core/css/MediaValuesInitialViewport.h"
6 6
7 #include "core/frame/FrameView.h" 7 #include "core/frame/FrameView.h"
8 #include "core/testing/DummyPageHolder.h" 8 #include "core/testing/DummyPageHolder.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 namespace blink { 11 namespace blink {
12 12
13 class MediaValuesInitialViewportTest : public ::testing::Test { 13 class MediaValuesInitialViewportTest : public ::testing::Test {
14 protected: 14 protected:
15 Document& document() const { return m_dummyPageHolder->document(); } 15 Document& document() const { return m_dummyPageHolder->document(); }
16 16
17 private: 17 private:
18 void SetUp() override { 18 void SetUp() override {
19 m_dummyPageHolder = DummyPageHolder::create(IntSize(320, 480)); 19 m_dummyPageHolder = DummyPageHolder::create(IntSize(320, 480));
20 document().view()->setInitialViewportSize(IntSize(320, 480));
20 } 21 }
21 22
22 std::unique_ptr<DummyPageHolder> m_dummyPageHolder; 23 std::unique_ptr<DummyPageHolder> m_dummyPageHolder;
23 }; 24 };
24 25
25 TEST_F(MediaValuesInitialViewportTest, InitialViewportSize) { 26 TEST_F(MediaValuesInitialViewportTest, InitialViewportSize) {
26 FrameView* view = document().view(); 27 FrameView* view = document().view();
27 ASSERT_TRUE(view); 28 ASSERT_TRUE(view);
28 EXPECT_TRUE(view->layoutSizeFixedToFrameSize()); 29 EXPECT_TRUE(view->layoutSizeFixedToFrameSize());
29 30
30 MediaValues* mediaValues = 31 MediaValues* mediaValues =
31 MediaValuesInitialViewport::create(*document().frame()); 32 MediaValuesInitialViewport::create(*document().frame());
32 EXPECT_EQ(320, mediaValues->viewportWidth()); 33 EXPECT_EQ(320, mediaValues->viewportWidth());
33 EXPECT_EQ(480, mediaValues->viewportHeight()); 34 EXPECT_EQ(480, mediaValues->viewportHeight());
34 35
35 view->setLayoutSizeFixedToFrameSize(false); 36 view->setLayoutSizeFixedToFrameSize(false);
36 view->setLayoutSize(IntSize(800, 600)); 37 view->setLayoutSize(IntSize(800, 600));
37 EXPECT_EQ(320, mediaValues->viewportWidth()); 38 EXPECT_EQ(320, mediaValues->viewportWidth());
38 EXPECT_EQ(480, mediaValues->viewportHeight()); 39 EXPECT_EQ(480, mediaValues->viewportHeight());
39 } 40 }
40 41
41 } // namespace blink 42 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/MediaValuesInitialViewport.cpp ('k') | third_party/WebKit/Source/core/frame/FrameView.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698