third_party/WebKit/LayoutTests/media/video-controls-visibility-multimodal-mouse-after-touch.html - Issue 2431583004: Media Controls: don't activate buttons when tapping on hidden controls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/video-controls-visibility-multimodal-mouse-after-touch.html

Issue 2431583004: Media Controls: don't activate buttons when tapping on hidden controls. (Closed)

Patch Set: review comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/media-controls-tap-show-controls-without-activating.html ('k') | third_party/WebKit/Source/core/html/shadow/MediaControlElements.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/video-controls-visibility-multimodal-mouse-after-touch.html

diff --git a/third_party/WebKit/LayoutTests/media/video-controls-visibility-multimodal-mouse-after-touch.html b/third_party/WebKit/LayoutTests/media/video-controls-visibility-multimodal-mouse-after-touch.html

index 239d9b5e284d47278d0ceb905e338fc029871654..637cf24f81dafbf7f1cfcd1ae472d390dc1426be 100644

--- a/third_party/WebKit/LayoutTests/media/video-controls-visibility-multimodal-mouse-after-touch.html

+++ b/third_party/WebKit/LayoutTests/media/video-controls-visibility-multimodal-mouse-after-touch.html

@@ -20,15 +20,15 @@ async_test(function(t) {

assert_false(video.paused);

// And then hover the control with the mouse.

+ eventSender.mouseMoveTo(0, 0);

eventSender.mouseMoveTo(coords[0], coords[1]);

// And the controls should remain visible.

runAfterHideMediaControlsTimerFired(t.step_func_done(function() {

- var controls = mediaControlsButton(video, "panel");

- assert_equals(getComputedStyle(controls).opacity, "1");

+ assert_true(isControlsPanelVisible(video));

}), video);

});

video.src = findMediaFile("video", "content/test");

});

-</script>

+</script>