Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Side by Side Diff: chrome/browser/ui/webui/welcome_handler.h

Issue 2431543003: WelcomeHandler sometimes has browser_ null in ctor (Closed)
Patch Set: Change to GetBrowser()->ShowModalSigninWindow Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/welcome_handler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_WELCOME_HANDLER_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_WELCOME_HANDLER_H_
6 #define CHROME_BROWSER_UI_WEBUI_WELCOME_HANDLER_H_ 6 #define CHROME_BROWSER_UI_WEBUI_WELCOME_HANDLER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "content/public/browser/web_ui_message_handler.h" 9 #include "content/public/browser/web_ui_message_handler.h"
10 #include "google_apis/gaia/oauth2_token_service.h" 10 #include "google_apis/gaia/oauth2_token_service.h"
(...skipping 19 matching lines...) Expand all
30 enum WelcomeResult { 30 enum WelcomeResult {
31 DEFAULT = 0, 31 DEFAULT = 0,
32 SIGNED_IN, // User clicked the "Sign In" button and completed sign-in. 32 SIGNED_IN, // User clicked the "Sign In" button and completed sign-in.
33 DECLINED // User clicked the "No Thanks" button. 33 DECLINED // User clicked the "No Thanks" button.
34 }; 34 };
35 35
36 void HandleActivateSignIn(const base::ListValue* args); 36 void HandleActivateSignIn(const base::ListValue* args);
37 void HandleUserDecline(const base::ListValue* args); 37 void HandleUserDecline(const base::ListValue* args);
38 void GoToNewTabPage(); 38 void GoToNewTabPage();
39 39
40 Browser* GetBrowser();
41
40 Profile* profile_; 42 Profile* profile_;
41 Browser* browser_;
42 ProfileOAuth2TokenService* oauth2_token_service_; 43 ProfileOAuth2TokenService* oauth2_token_service_;
43 WelcomeResult result_; 44 WelcomeResult result_;
44 45
45 DISALLOW_COPY_AND_ASSIGN(WelcomeHandler); 46 DISALLOW_COPY_AND_ASSIGN(WelcomeHandler);
46 }; 47 };
47 48
48 #endif // CHROME_BROWSER_UI_WEBUI_WELCOME_HANDLER_H_ 49 #endif // CHROME_BROWSER_UI_WEBUI_WELCOME_HANDLER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/webui/welcome_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698