Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2431513004: Crash fix: Ignore mojo Create() calls after RFH is dead. (Closed)

Created:
4 years, 2 months ago by miu
Modified:
4 years, 2 months ago
Reviewers:
xjz
CC:
chromium-reviews, imcheng+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Crash fix: Ignore mojo Create() calls after RFH is dead. Mojo posted tasks to call the RemoterFactory's Create() method; but while these tasks were posted before the associated RenderFrameHost was destroyed, they were being run after the RFH was destroyed. This change solves the problem by storing the process/routing IDs of the RFH and performing a look-up-by-ID before each use of the RFH. BUG=655686 Committed: https://crrev.com/951fc9d0e3dc2db9666b803eab941bf4c53c0a4d Cr-Commit-Position: refs/heads/master@{#426146}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M chrome/browser/media/cast_remoting_connector.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/media/cast_remoting_connector.cc View 3 chunks +19 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
miu
xjz: PTAL.
4 years, 2 months ago (2016-10-18 20:44:45 UTC) #2
xjz
lgtm
4 years, 2 months ago (2016-10-18 21:12:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431513004/1
4 years, 2 months ago (2016-10-18 22:24:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/255468)
4 years, 2 months ago (2016-10-18 23:28:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431513004/1
4 years, 2 months ago (2016-10-19 05:43:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 11:06:55 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:06:55 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/951fc9d0e3dc2db9666b803eab941bf4c53c0a4d
Cr-Commit-Position: refs/heads/master@{#426146}

Powered by Google App Engine
This is Rietveld 408576698