Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: third_party/WebKit/Source/core/css/RemoteFontFaceSource.h

Issue 2431503002: Log web fonts intervention result more accurately (Closed)
Patch Set: Addressed comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/RemoteFontFaceSource.h
diff --git a/third_party/WebKit/Source/core/css/RemoteFontFaceSource.h b/third_party/WebKit/Source/core/css/RemoteFontFaceSource.h
index fb76fee8c0b7fca48575fa6c930769f05f8be3b1..3a98d02eec0059f7eeced4e264d537abd60e2bbe 100644
--- a/third_party/WebKit/Source/core/css/RemoteFontFaceSource.h
+++ b/third_party/WebKit/Source/core/css/RemoteFontFaceSource.h
@@ -76,14 +76,17 @@ class RemoteFontFaceSource final : public CSSFontFaceSource,
FromNetwork
};
- FontLoadHistograms(DataSource dataSource)
+ FontLoadHistograms(DataSource dataSource, FontDisplay fontDisplay)
: m_loadStartTime(0),
m_blankPaintTime(0),
m_isLongLimitExceeded(false),
- m_dataSource(dataSource) {}
+ m_dataSource(dataSource),
+ m_fontDisplay(fontDisplay) {}
void loadStarted();
void fallbackFontPainted(DisplayPeriod);
- void fontLoaded(bool isInterventionTriggered);
+ void fontLoaded(bool isCorsFailed,
+ bool loadError,
+ bool isInterventionTriggered);
void longLimitExceeded(bool isInterventionTriggered);
void recordFallbackTime(const FontResource*);
void recordRemoteFont(const FontResource*);
@@ -99,6 +102,7 @@ class RemoteFontFaceSource final : public CSSFontFaceSource,
double m_blankPaintTime;
bool m_isLongLimitExceeded;
DataSource m_dataSource;
+ FontDisplay m_fontDisplay;
};
void switchToSwapPeriod();

Powered by Google App Engine
This is Rietveld 408576698