Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2431423002:
Add variables to simplify code signing on iOS. (Closed)
DescriptionAdd variables to simplify code signing on iOS.
Add variables to configure the generated bundle identifier prefix (known
as "Organization Identifier" in Xcode) and to enable automatically managed
certs.
Those variables are currently unused in order to avoid breaking the iOS
downstream tree when they land. Once the Chrome on iOS private code has
been updated to override them, they will be connected to the build.
BUG=613543
Committed: https://crrev.com/ff5bbc987d0d57f509a6d191285c9c4c8729ff58
Cr-Commit-Position: refs/heads/master@{#426293}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Address comments. #Messages
Total messages: 20 (13 generated)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
sdefresne@chromium.org changed reviewers: + justincohen@google.com
Please take a look and send to CQ if lgty.
The CQ bit was unchecked by sdefresne@chromium.org
justincohen@chromium.org changed reviewers: + justincohen@chromium.org
LGTM with clarification. https://codereview.chromium.org/2431423002/diff/1/build/config/ios/ios_sdk.gni File build/config/ios/ios_sdk.gni (right): https://codereview.chromium.org/2431423002/diff/1/build/config/ios/ios_sdk.gn... build/config/ios/ios_sdk.gni:36: # to avoid running out of free certificates. We aren't requiring developers to use a free account, they can still use dev or enterprise paid accounts. Instead can we say something to the effect: ... same bundle id to avoid running out of certificates if using a free account. The title should change as well, something like '... configure app bundle id prefix and to enable automatically managed certs.' Apologies if I created this confusion when I put text in the bug!
Description was changed from ========== Add variables to configure app bundle id prefix and to enable free certs. The variables are not yet used (in order to avoid breaking Chrome on iOS downstream autoroller) but will be in the next CL. BUG=613543 ========== to ========== Add variables to simplify code signing on iOS. Add variables to configure the generated bundle identifier prefix (known as "Organization Identifier" in Xcode) and to enable automatically managed certs. Those variables are currently unused in order to avoid breaking the iOS downstream tree when they land. Once the Chrome on iOS private code has been updated to override them, they will be connected to the build. BUG=613543 ==========
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Description was changed from ========== Add variables to simplify code signing on iOS. Add variables to configure the generated bundle identifier prefix (known as "Organization Identifier" in Xcode) and to enable automatically managed certs. Those variables are currently unused in order to avoid breaking the iOS downstream tree when they land. Once the Chrome on iOS private code has been updated to override them, they will be connected to the build. BUG=613543 ========== to ========== Add variables to simplify code signing on iOS. Add variables to configure the generated bundle identifier prefix (known as "Organization Identifier" in Xcode) and to enable automatically managed certs. Those variables are currently unused in order to avoid breaking the iOS downstream tree when they land. Once the Chrome on iOS private code has been updated to override them, they will be connected to the build. BUG=613543 ==========
PTAL
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
still LGTM
The CQ bit was unchecked by sdefresne@chromium.org
The CQ bit was checked by sdefresne@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from justincohen@chromium.org Link to the patchset: https://chromiumcodereview.appspot.com/2431423002/#ps20001 (title: "Address comments.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add variables to simplify code signing on iOS. Add variables to configure the generated bundle identifier prefix (known as "Organization Identifier" in Xcode) and to enable automatically managed certs. Those variables are currently unused in order to avoid breaking the iOS downstream tree when they land. Once the Chrome on iOS private code has been updated to override them, they will be connected to the build. BUG=613543 ========== to ========== Add variables to simplify code signing on iOS. Add variables to configure the generated bundle identifier prefix (known as "Organization Identifier" in Xcode) and to enable automatically managed certs. Those variables are currently unused in order to avoid breaking the iOS downstream tree when they land. Once the Chrome on iOS private code has been updated to override them, they will be connected to the build. BUG=613543 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add variables to simplify code signing on iOS. Add variables to configure the generated bundle identifier prefix (known as "Organization Identifier" in Xcode) and to enable automatically managed certs. Those variables are currently unused in order to avoid breaking the iOS downstream tree when they land. Once the Chrome on iOS private code has been updated to override them, they will be connected to the build. BUG=613543 ========== to ========== Add variables to simplify code signing on iOS. Add variables to configure the generated bundle identifier prefix (known as "Organization Identifier" in Xcode) and to enable automatically managed certs. Those variables are currently unused in order to avoid breaking the iOS downstream tree when they land. Once the Chrome on iOS private code has been updated to override them, they will be connected to the build. BUG=613543 Committed: https://crrev.com/ff5bbc987d0d57f509a6d191285c9c4c8729ff58 Cr-Commit-Position: refs/heads/master@{#426293} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ff5bbc987d0d57f509a6d191285c9c4c8729ff58 Cr-Commit-Position: refs/heads/master@{#426293} |
