Web MIDI: move MIDI message validating logic into message_util.{cc|h}

Web MIDI: move MIDI message validating logic into message_util.{cc|h}

There are two motivations for this changes:

 1. To reduce duplicated message handling code
 2. To simplify MidiHost to make coming mojofication change as much
    simple as possible

Also this change rename midi_message_util to message_util
since now that midi has a dedicated namespace.

BUG=339749, 582327
Committed: https://crrev.com/698d79dd86089e67c1f678147f3172b4add13312
Cr-Commit-Position: refs/heads/master@{#426454}

[Takashi Toyoshima, 2016-10-19 12:49:45]

Description was changed from

==========
Web MIDI: move MIDI message validating logic into message_util.{cc|h}

There are two motivations for this changes:

 1. To reduce duplicated message handling code
 2. To simplify MidiHost to make coming mojofication change as much
    simple as possible

BUG=339749, 582327
==========

to

==========
Web MIDI: move MIDI message validating logic into message_util.{cc|h}

There are two motivations for this changes:

 1. To reduce duplicated message handling code
 2. To simplify MidiHost to make coming mojofication change as much
    simple as possible

Also this change rename midi_message_util to message_util
since now that midi has a dedicated namespace.

BUG=339749, 582327
==========

[Takashi Toyoshima, 2016-10-19 12:49:45]

toyoshim@chromium.org changed reviewers:
+ yukawa@chromium.org

[Takashi Toyoshima, 2016-10-19 12:53:12]

Hi, yukawa.
I'm asking you a review because you contributed very much to message validation
code.
If you don't have much time, I'd ask yhirano.

[Takashi Toyoshima, 2016-10-19 13:44:25]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 13:44:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 14:14:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 14:14:03]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[yukawa, 2016-10-19 20:11:20]

LGTM with minor comments.

https://codereview.chromium.org/2431393002/diff/1/media/midi/message_util.cc
File media/midi/message_util.cc (right):

https://codereview.chromium.org/2431393002/diff/1/media/midi/message_util.cc#...
media/midi/message_util.cc:94: waiting_data_length =
midi::GetMessageLength(current);
Can we drop midi:: ?

     waiting_data_length = GetMessageLength(current);

https://codereview.chromium.org/2431393002/diff/1/media/midi/midi_message_que...
File media/midi/midi_message_queue.cc (right):

https://codereview.chromium.org/2431393002/diff/1/media/midi/midi_message_que...
media/midi/midi_message_queue.cc:14: using midi::kSysExByte;
Do we need this?

https://codereview.chromium.org/2431393002/diff/1/media/midi/midi_message_que...
media/midi/midi_message_queue.cc:15: using midi::kEndOfSysExByte;
Do we need this?

[Takashi Toyoshima, 2016-10-20 05:18:18]

Thanks!

Yeah, good catches. Also, I fixed one caller code for win to fix a build break.

https://codereview.chromium.org/2431393002/diff/1/media/midi/message_util.cc
File media/midi/message_util.cc (right):

https://codereview.chromium.org/2431393002/diff/1/media/midi/message_util.cc#...
media/midi/message_util.cc:94: waiting_data_length =
midi::GetMessageLength(current);
On 2016/10/19 20:11:20, yukawa wrote:
> Can we drop midi:: ?
> 
>      waiting_data_length = GetMessageLength(current);

Done.

https://codereview.chromium.org/2431393002/diff/1/media/midi/midi_message_que...
File media/midi/midi_message_queue.cc (right):

https://codereview.chromium.org/2431393002/diff/1/media/midi/midi_message_que...
media/midi/midi_message_queue.cc:14: using midi::kSysExByte;
On 2016/10/19 20:11:20, yukawa wrote:
> Do we need this?

Done.

https://codereview.chromium.org/2431393002/diff/1/media/midi/midi_message_que...
media/midi/midi_message_queue.cc:15: using midi::kEndOfSysExByte;
On 2016/10/19 20:11:20, yukawa wrote:
> Do we need this?

Done.

[yukawa, 2016-10-20 05:20:44]

still LGTM.

[Takashi Toyoshima, 2016-10-20 05:26:37]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2016-10-20 05:26:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 06:31:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 06:31:47]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Takashi Toyoshima, 2016-10-20 08:02:37]

Oh, size_t warnings on windows seem to be disabled for content/, and isn't for
midi/.
Let me add explicit cast to remove this warning on win_chromium_x64_rel_ng.

[Takashi Toyoshima, 2016-10-20 09:20:51]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2016-10-20 09:20:51]

The patchset sent to the CQ was uploaded after l-g-t-m from yukawa@chromium.org
Link to the patchset: https://codereview.chromium.org/2431393002/#ps40001
(title: "build fix")

[commit-bot: I haz the power, 2016-10-20 09:21:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 12:13:48]

Description was changed from

==========
Web MIDI: move MIDI message validating logic into message_util.{cc|h}

There are two motivations for this changes:

 1. To reduce duplicated message handling code
 2. To simplify MidiHost to make coming mojofication change as much
    simple as possible

Also this change rename midi_message_util to message_util
since now that midi has a dedicated namespace.

BUG=339749, 582327
==========

to

==========
Web MIDI: move MIDI message validating logic into message_util.{cc|h}

There are two motivations for this changes:

 1. To reduce duplicated message handling code
 2. To simplify MidiHost to make coming mojofication change as much
    simple as possible

Also this change rename midi_message_util to message_util
since now that midi has a dedicated namespace.

BUG=339749, 582327
==========

[commit-bot: I haz the power, 2016-10-20 12:13:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-21 13:17:31]

Description was changed from

==========
Web MIDI: move MIDI message validating logic into message_util.{cc|h}

There are two motivations for this changes:

 1. To reduce duplicated message handling code
 2. To simplify MidiHost to make coming mojofication change as much
    simple as possible

Also this change rename midi_message_util to message_util
since now that midi has a dedicated namespace.

BUG=339749, 582327
==========

to

==========
Web MIDI: move MIDI message validating logic into message_util.{cc|h}

There are two motivations for this changes:

 1. To reduce duplicated message handling code
 2. To simplify MidiHost to make coming mojofication change as much
    simple as possible

Also this change rename midi_message_util to message_util
since now that midi has a dedicated namespace.

BUG=339749, 582327

Committed: https://crrev.com/698d79dd86089e67c1f678147f3172b4add13312
Cr-Commit-Position: refs/heads/master@{#426454}
==========

[commit-bot: I haz the power, 2016-10-21 13:17:32]

Patchset 3 (id:??) landed as
https://crrev.com/698d79dd86089e67c1f678147f3172b4add13312
Cr-Commit-Position: refs/heads/master@{#426454}