Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2431373006: DevTools: Light blue highlight when hovering in Sources Navigator (Closed)

Created:
4 years, 2 months ago by einbinder
Modified:
4 years, 2 months ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Light blue highlight when hovering in Sources Navigator BUG=none Committed: https://crrev.com/c067174d429128e4d37e52bbd2abc9dd84de20d0 Cr-Commit-Position: refs/heads/master@{#426981}

Patch Set 1 #

Patch Set 2 : space #

Total comments: 2

Patch Set 3 : space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sources/navigatorTree.css View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
einbinder
ptal
4 years, 2 months ago (2016-10-21 23:56:37 UTC) #3
einbinder
On 2016/10/21 at 23:56:37, einbinder wrote: > ptal http://imgur.com/UjLZoKc
4 years, 2 months ago (2016-10-22 00:02:16 UTC) #4
lushnikov
lgtm https://codereview.chromium.org/2431373006/diff/40001/third_party/WebKit/Source/devtools/front_end/sources/navigatorTree.css File third_party/WebKit/Source/devtools/front_end/sources/navigatorTree.css (right): https://codereview.chromium.org/2431373006/diff/40001/third_party/WebKit/Source/devtools/front_end/sources/navigatorTree.css#newcode73 third_party/WebKit/Source/devtools/front_end/sources/navigatorTree.css:73: display:block; nit: missing space
4 years, 2 months ago (2016-10-22 00:55:39 UTC) #5
einbinder
https://codereview.chromium.org/2431373006/diff/40001/third_party/WebKit/Source/devtools/front_end/sources/navigatorTree.css File third_party/WebKit/Source/devtools/front_end/sources/navigatorTree.css (right): https://codereview.chromium.org/2431373006/diff/40001/third_party/WebKit/Source/devtools/front_end/sources/navigatorTree.css#newcode73 third_party/WebKit/Source/devtools/front_end/sources/navigatorTree.css:73: display:block; On 2016/10/22 at 00:55:38, lushnikov wrote: > nit: ...
4 years, 2 months ago (2016-10-22 02:32:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431373006/60001
4 years, 2 months ago (2016-10-22 02:33:05 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 2 months ago (2016-10-22 05:37:58 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-22 06:12:25 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/c067174d429128e4d37e52bbd2abc9dd84de20d0
Cr-Commit-Position: refs/heads/master@{#426981}

Powered by Google App Engine
This is Rietveld 408576698