Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2431363002: [interpreter] Don't canonicalize results of feedback collecting handlers. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
mythria
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Don't canonicalize results of feedback collecting handlers. For binary operations that collect feedback (in Ignition), don't canonicalize when the operation itself is already performed in Float64. This is the first step to fix the performance difference we still see between TurboFan and TurboFan+Ignition. R=mythria@chromium.org Committed: https://crrev.com/3c10b97c343716be22144b30d67bc153189550d2 Cr-Commit-Position: refs/heads/master@{#40428}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M src/code-stubs.cc View 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-19 09:52:22 UTC) #1
Benedikt Meurer
Hey Mythri, This makes Ignition more compatible with the default configuration (which should help with ...
4 years, 2 months ago (2016-10-19 09:53:05 UTC) #4
mythria
Thanks, LGTM.
4 years, 2 months ago (2016-10-19 10:07:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431363002/1
4 years, 2 months ago (2016-10-19 10:31:21 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 11:13:16 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:06:05 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c10b97c343716be22144b30d67bc153189550d2
Cr-Commit-Position: refs/heads/master@{#40428}

Powered by Google App Engine
This is Rietveld 408576698