Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2431353002: Fixing allow_csp_from.html test and enabling it back in sit-per-process (Closed)

Created:
4 years, 2 months ago by amalika
Modified:
4 years, 2 months ago
Reviewers:
Mike West, alexmos
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing allow_csp_from.html test and enabling it back in sit-per-process BUG=657081 Committed: https://crrev.com/ffd0c9861f0a04be58333ce02a1a588dba99319e Cr-Commit-Position: refs/heads/master@{#426444}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Style #

Messages

Total messages: 10 (4 generated)
amalika
The onmessage event in the case of EXPECT_BLOCK should be unreached only by the current ...
4 years, 2 months ago (2016-10-19 08:51:27 UTC) #2
alexmos
LGTM, thanks for fixing! I ran linux_site_isolation on this and confirmed that it's working now. ...
4 years, 2 months ago (2016-10-19 17:16:06 UTC) #3
Mike West
Yup, LGTM too. Thanks!
4 years, 2 months ago (2016-10-20 09:30:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431353002/20001
4 years, 2 months ago (2016-10-20 09:36:19 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-20 10:27:37 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:17:07 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ffd0c9861f0a04be58333ce02a1a588dba99319e
Cr-Commit-Position: refs/heads/master@{#426444}

Powered by Google App Engine
This is Rietveld 408576698