Only rewrite all statements in a block if we're in a breakable scope

Only rewrite all statements in a block if we're in a breakable scope

BUG=

Committed: https://crrev.com/cc782c0a1616e1d996deb5183cd9dc574bc06bfc
Cr-Commit-Position: refs/heads/master@{#40492}

[Toon Verwaest, 2016-10-19 07:25:56]

verwaest@chromium.org changed reviewers:
+ adamk@chromium.org

[Toon Verwaest, 2016-10-19 07:25:57]

ptal

[adamk, 2016-10-19 14:55:25]

I'm missing how this handles finding the last non-empty statement. e.g.,
eval("42; var x") needs to return 42. Kicking off a try run now...

Also, I'd like to make sure we have tests for both labeled and unlabeled blocks
(I don't see any labeled blocks in the big completion.js test).

[adamk, 2016-10-19 14:55:31]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 14:55:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 15:11:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 15:12:00]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/11147)
  v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)

[Toon Verwaest, 2016-10-19 15:49:48]

Good point, I'll look into it tomorrow. Odd we don't have a single test in our
own suite for that case...

[Toon Verwaest, 2016-10-20 08:06:45]

The CQ bit was checked by verwaest@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 08:06:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Toon Verwaest, 2016-10-20 08:07:12]

Now I walk backwards until the value is_set_; except if breakable_.

[Toon Verwaest, 2016-10-20 08:10:13]

The CQ bit was checked by verwaest@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 08:10:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 08:45:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 08:45:03]

Dry run: This issue passed the CQ dry run.

[tammie.h.oneal, 2016-10-20 08:55:02]

Very good point!We have missed tests for unlabeled blocks at
http://buyessayfast.net/ and had a lot of bugs later.

[adamk, 2016-10-20 15:39:06]

lgtm once this has a comment

https://codereview.chromium.org/2431273002/diff/40001/src/parsing/rewriter.cc
File src/parsing/rewriter.cc (right):

https://codereview.chromium.org/2431273002/diff/40001/src/parsing/rewriter.cc...
src/parsing/rewriter.cc:127: for (int i = statements->length() - 1; i >= 0 &&
(breakable_ || !is_set_);
That's quite a fancy for loop, please add a comment explaining the reasoning
here.

[Toon Verwaest, 2016-10-21 08:04:41]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-10-21 08:04:41]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2431273002/#ps60001
(title: "comment")

[commit-bot: I haz the power, 2016-10-21 08:04:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 08:50:40]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-17 22:09:13]

Description was changed from

==========
Only rewrite all statements in a block if we're in a breakable scope

BUG=
==========

to

==========
Only rewrite all statements in a block if we're in a breakable scope

BUG=

Committed: https://crrev.com/cc782c0a1616e1d996deb5183cd9dc574bc06bfc
Cr-Commit-Position: refs/heads/master@{#40492}
==========

[commit-bot: I haz the power, 2016-11-17 22:09:15]

Patchset 4 (id:??) landed as
https://crrev.com/cc782c0a1616e1d996deb5183cd9dc574bc06bfc
Cr-Commit-Position: refs/heads/master@{#40492}