Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. | 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. |
| 3 Use of this source code is governed by a BSD-style license that can be | 3 Use of this source code is governed by a BSD-style license that can be |
| 4 found in the LICENSE file. --> | 4 found in the LICENSE file. --> |
| 5 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android" | 5 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android" |
| 6 android:layout_width="match_parent" | 6 android:layout_width="match_parent" |
| 7 android:layout_height="48dp" | 7 android:layout_height="48dp" |
| 8 android:paddingStart="16dp" | 8 android:paddingStart="16dp" |
| 9 android:paddingEnd="16dp" | 9 android:paddingEnd="16dp" |
| 10 android:background="@drawable/item_chooser_row_background"> | 10 android:background="@drawable/item_chooser_row_background"> |
| 11 <TextView | 11 <!-- contentDescription is added at runtime. --> |
|
Ian Wen
2016/10/26 21:53:32
Please fix the indentation. Child element should i
| |
| 12 android:id="@+id/description" | 12 <ImageView |
| 13 android:layout_width="match_parent" | 13 android:id="@+id/icon" |
| 14 android:layout_height="wrap_content" | 14 android:contentDescription="@null" |
| 15 android:ellipsize="end" | 15 android:layout_width="24dp" |
| 16 android:maxLines="1" | 16 android:layout_height="24dp" |
| 17 android:textColor="@color/item_chooser_row_text_color" | 17 android:layout_centerVertical="true" |
| 18 android:layout_centerVertical="true"/> | 18 android:layout_marginEnd="32dp"/> |
| 19 <TextView | |
| 20 android:id="@+id/description" | |
| 21 android:layout_width="match_parent" | |
| 22 android:layout_height="wrap_content" | |
| 23 android:layout_centerVertical="true" | |
| 24 android:layout_toEndOf="@+id/icon" | |
| 25 android:ellipsize="end" | |
| 26 android:maxLines="1" | |
| 27 android:textColor="@color/item_chooser_row_text_color"/> | |
| 19 </RelativeLayout> | 28 </RelativeLayout> |
| OLD | NEW |