Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2431213003: X87: [wasm] Trim graph before scheduling. (Closed)

Created:
4 years, 2 months ago by zhengxing.li
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [wasm] Trim graph before scheduling. port 990236825974e683640f9ca56ddd53e3e831a278 (r40446) original commit message: The scheduler expects a trimmed graph, so we have to trim the graph before scheduling. BUG= Committed: https://crrev.com/3cc949e3bedf0fdc1c49b78dcb52cc50e37b96ac Cr-Commit-Position: refs/heads/master@{#40454}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -34 lines) Patch
M src/compiler/x87/instruction-selector-x87.cc View 2 chunks +65 lines, -34 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
zhengxing.li
PTAL, thanks!
4 years, 2 months ago (2016-10-20 02:26:12 UTC) #2
ahaas
lgtm
4 years, 2 months ago (2016-10-20 07:35:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431213003/1
4 years, 2 months ago (2016-10-20 07:37:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/26911)
4 years, 2 months ago (2016-10-20 07:53:51 UTC) #7
Weiliang
lgtm
4 years, 2 months ago (2016-10-20 08:20:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431213003/1
4 years, 2 months ago (2016-10-20 08:21:35 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 08:27:15 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:07:24 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3cc949e3bedf0fdc1c49b78dcb52cc50e37b96ac
Cr-Commit-Position: refs/heads/master@{#40454}

Powered by Google App Engine
This is Rietveld 408576698