Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Issue 2431183004: [tools] Add legend to IC explorer. (Closed)

Created:
4 years, 2 months ago by Franzi
Modified:
4 years, 1 month ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tools] Add legend to IC explorer. Add legend that explains the abbreviations for different IC states to IC explorer. Copied from ic.cc. BUG= Committed: https://crrev.com/db733efda1261d65aae750927bf58ca3f4e0fecd Cr-Commit-Position: refs/heads/master@{#40433}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M tools/ic-explorer.html View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Franzi
Hi Camillo, Please take a look. I tried to match the style with minimal CSS ...
4 years, 2 months ago (2016-10-19 10:21:39 UTC) #2
Camillo Bruni
lgtm, thanks!
4 years, 2 months ago (2016-10-19 11:29:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431183004/1
4 years, 2 months ago (2016-10-19 11:36:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 12:48:03 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:06:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db733efda1261d65aae750927bf58ca3f4e0fecd
Cr-Commit-Position: refs/heads/master@{#40433}

Powered by Google App Engine
This is Rietveld 408576698