Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2431163004: [sensors] Make generic_sensor a component (Closed)

Created:
4 years, 2 months ago by darktears
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sensors] Make generic_sensor a component The motivation is to allow classes to be exported (for component builds) so that a browser test can be written outside of device/ and on top of content/ and the needed classes can be used to write a fake/mock provider with fake/mock sensors (the test will come in follow up CL). The motivation is to test end to end the feature in a cross platform and non hardware dependent way and checking JavaScript behavior. BUG=606766 Committed: https://crrev.com/ed8fd058823b1502c6290e19c2c4eac7f8739db5 Cr-Commit-Position: refs/heads/master@{#426567}

Patch Set 1 #

Patch Set 2 : v2 #

Patch Set 3 : Fix Windows build #

Patch Set 4 : Fix Win Clang and Android build #

Patch Set 5 : Win Clang #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -10 lines) Patch
M device/generic_sensor/BUILD.gn View 1 2 3 4 4 chunks +9 lines, -2 lines 0 comments Download
M device/generic_sensor/android/sensors_jni_registrar.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
A device/generic_sensor/generic_sensor_export.h View 1 chunk +29 lines, -0 lines 0 comments Download
M device/generic_sensor/platform_sensor.h View 2 chunks +3 lines, -1 line 0 comments Download
M device/generic_sensor/platform_sensor_provider.h View 1 chunk +3 lines, -1 line 0 comments Download
M device/generic_sensor/platform_sensor_provider_base.h View 1 chunk +3 lines, -1 line 0 comments Download
M device/generic_sensor/public/cpp/BUILD.gn View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M device/generic_sensor/public/cpp/platform_sensor_configuration.h View 1 chunk +2 lines, -1 line 0 comments Download
M device/generic_sensor/public/cpp/sensor_reading.h View 2 chunks +2 lines, -1 line 0 comments Download
M device/generic_sensor/public/interfaces/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M device/generic_sensor/public/interfaces/sensor.typemap View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M device/generic_sensor/sensor_provider_impl.h View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 26 (19 generated)
darktears
4 years, 2 months ago (2016-10-19 19:28:21 UTC) #5
darktears
On 2016/10/19 at 21:04:07, darktears wrote: > The CQ bit was checked by alexis.menard@intel.com to ...
4 years, 2 months ago (2016-10-19 21:04:40 UTC) #12
Mikhail
lgtm
4 years, 2 months ago (2016-10-20 07:43:40 UTC) #20
timvolodine
lgtm the testing in description can probably be done without it being a component, but ...
4 years, 2 months ago (2016-10-20 19:07:17 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431163004/80001
4 years, 2 months ago (2016-10-20 19:36:48 UTC) #23
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 2 months ago (2016-10-20 19:45:49 UTC) #24
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:21:29 UTC) #26
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/ed8fd058823b1502c6290e19c2c4eac7f8739db5
Cr-Commit-Position: refs/heads/master@{#426567}

Powered by Google App Engine
This is Rietveld 408576698