scripts/slave/recipes/blink_trybot.expected/win_fail_debug_git.json - Issue 24311004: Use always_run v can_fail_build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/blink_trybot.expected/win_fail_debug_git.json

Issue 24311004: Use always_run v can_fail_build (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: rebase Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/blink_trybot.expected/win_fail_debug.json ('k') | scripts/slave/recipes/blink_trybot.expected/win_fail_release.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/blink_trybot.expected/win_fail_debug_git.json

diff --git a/scripts/slave/recipes/blink_trybot.expected/win_fail_debug_git.json b/scripts/slave/recipes/blink_trybot.expected/win_fail_debug_git.json

index ab038de245893f4695ad1eab1ef112cfce5aff17..9af7f2088963ff78a4b7ed50d56595c7de0841bc 100644

--- a/scripts/slave/recipes/blink_trybot.expected/win_fail_debug_git.json

+++ b/scripts/slave/recipes/blink_trybot.expected/win_fail_debug_git.json

@@ -100,6 +100,7 @@

"name": "gclient runhooks"

{

+ "abort_on_failure": true,

"cmd": [

"python",

"-u",

@@ -144,7 +145,7 @@

"name": "webkit_python_tests"

{

- "can_fail_build": false,

+ "always_run": true,

"cmd": [

"python",

"-u",

@@ -163,7 +164,7 @@

"name": "webkit_unit_tests"

{

- "can_fail_build": false,

+ "always_run": true,

"cmd": [

"python",

"-u",

@@ -182,7 +183,7 @@

"name": "weborigin_unittests"

{

- "can_fail_build": false,

+ "always_run": true,

"cmd": [

"python",

"-u",

@@ -201,6 +202,7 @@

"name": "wtf_unittests"

{

+ "always_run": true,

"can_fail_build": false,

"cmd": [

"python",

@@ -322,6 +324,7 @@

"name": "gclient runhooks (2)"

{

+ "abort_on_failure": true,

"cmd": [

"python",

"-u",

@@ -342,6 +345,7 @@

"name": "compile (2)"

{

+ "always_run": true,

"can_fail_build": false,

"cmd": [

"python",