Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: scripts/slave/recipe_modules/chromium/api.py

Issue 24311004: Use always_run v can_fail_build (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipe_api.py ('k') | scripts/slave/recipe_modules/step/api.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium/api.py
diff --git a/scripts/slave/recipe_modules/chromium/api.py b/scripts/slave/recipe_modules/chromium/api.py
index 59285615d2d8ece8780a54ea983704a0598f4733..f255521ff94577336910c52ea0f0ec11666986f9 100644
--- a/scripts/slave/recipe_modules/chromium/api.py
+++ b/scripts/slave/recipe_modules/chromium/api.py
@@ -41,7 +41,7 @@ class ChromiumApi(recipe_api.RecipeApi):
args.extend(targets)
return self.m.python(name or 'compile',
self.m.path.build('scripts', 'slave', 'compile.py'),
- args, **kwargs)
+ args, abort_on_failure=True, **kwargs)
def runtests(self, test, args=None, xvfb=False, name=None, annotate=None,
results_url=None, perf_dashboard_id=None, test_type=None,
@@ -85,8 +85,8 @@ class ChromiumApi(recipe_api.RecipeApi):
full_args.append(test)
full_args.extend(args)
- # By default, don't abort the recipe for a single test failure.
- kwargs.setdefault('can_fail_build', False)
+ # By default, always run the tests.
+ kwargs.setdefault('always_run', True)
return self.m.python(
name or t_name,
« no previous file with comments | « scripts/slave/recipe_api.py ('k') | scripts/slave/recipe_modules/step/api.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698