Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2431093004: PPC/s390: [wasm] Trim graph before scheduling. (Closed)

Created:
4 years, 2 months ago by JaideepBajwa
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [wasm] Trim graph before scheduling. Port 990236825974e683640f9ca56ddd53e3e831a278 Original commit message: The scheduler expects a trimmed graph, so we have to trim the graph before scheduling. R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/83e66947cc7be065fdd9979a61b708e43ba0ca5d Cr-Commit-Position: refs/heads/master@{#40475}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -83 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +20 lines, -13 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 2 chunks +59 lines, -27 lines 0 comments Download
M src/compiler/s390/code-generator-s390.cc View 1 chunk +20 lines, -13 lines 0 comments Download
M src/compiler/s390/instruction-selector-s390.cc View 2 chunks +62 lines, -30 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
JaideepBajwa
PTAL
4 years, 2 months ago (2016-10-20 12:49:09 UTC) #1
ahaas
lgtm
4 years, 2 months ago (2016-10-20 13:45:38 UTC) #2
john.yan
lgtm
4 years, 2 months ago (2016-10-20 13:54:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431093004/1
4 years, 2 months ago (2016-10-20 13:55:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 14:32:11 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:08:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83e66947cc7be065fdd9979a61b708e43ba0ca5d
Cr-Commit-Position: refs/heads/master@{#40475}

Powered by Google App Engine
This is Rietveld 408576698