Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: net/quic/core/quic_stream_sequencer_test.cc

Issue 2430973004: Landing Recent QUIC changes until 10:38 AM, Oct 17, 2016 UTC-4 (Closed)
Patch Set: Improving flagsaver logging Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_stream_sequencer_buffer_test.cc ('k') | net/quic/core/quic_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_stream_sequencer_test.cc
diff --git a/net/quic/core/quic_stream_sequencer_test.cc b/net/quic/core/quic_stream_sequencer_test.cc
index b3b473f020a8cd85dbb8c8f835f4462e406fcf4f..3903093e999fe4e7706f0b4eb36e5c1f7d2a6b72 100644
--- a/net/quic/core/quic_stream_sequencer_test.cc
+++ b/net/quic/core/quic_stream_sequencer_test.cc
@@ -662,8 +662,10 @@ TEST_F(QuicStreamSequencerTest, OutOfOrderTimestamps) {
EXPECT_EQ(0u, sequencer_->NumBytesBuffered());
}
+// TODO(danzh): Figure out the way to implement this test case without the use
+// of unsupported StringPiece constructor.
+#if 0
TEST_F(QuicStreamSequencerTest, OnStreamFrameWithNullSource) {
- FLAGS_quic_stream_sequencer_buffer_debug = true;
// Pass in a frame with data pointing to null address, expect to close
// connection with error.
StringPiece source(nullptr, 5u);
@@ -672,9 +674,9 @@ TEST_F(QuicStreamSequencerTest, OnStreamFrameWithNullSource) {
QUIC_STREAM_SEQUENCER_INVALID_STATE, _));
sequencer_->OnStreamFrame(frame);
}
+#endif
TEST_F(QuicStreamSequencerTest, ReadvError) {
- FLAGS_quic_stream_sequencer_buffer_debug = true;
EXPECT_CALL(stream_, OnDataAvailable());
string source(100, 'a');
OnFrame(0u, source.data());
« no previous file with comments | « net/quic/core/quic_stream_sequencer_buffer_test.cc ('k') | net/quic/core/quic_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698