Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2430753002: Discard unused AppListPrefs code. (Closed)

Created:
4 years, 2 months ago by khmel
Modified:
4 years, 2 months ago
Reviewers:
calamity, stevenjb, benwells, sky
CC:
chromium-reviews, tfarina, Matt Giuca
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Discard unused AppListPrefs code. This CL discard unused code that monitors changes in app list model but does not expose any functionality. BUG=641535 Test=git cl try Committed: https://crrev.com/b8997b03c95df27570d0beab45cc42fe1df95c20 Cr-Commit-Position: refs/heads/master@{#426283}

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -591 lines) Patch
M chrome/browser/prefs/browser_prefs.cc View 1 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_app_list_sync_test.cc View 1 3 chunks +2 lines, -40 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 2 chunks +0 lines, -6 lines 0 comments Download
D chrome/browser/ui/app_list/app_list_prefs.h View 1 chunk +0 lines, -99 lines 0 comments Download
D chrome/browser/ui/app_list/app_list_prefs.cc View 1 chunk +0 lines, -129 lines 0 comments Download
D chrome/browser/ui/app_list/app_list_prefs_factory.h View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/browser/ui/app_list/app_list_prefs_factory.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_syncable_service.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_syncable_service.cc View 3 chunks +0 lines, -6 lines 0 comments Download
D chrome/browser/ui/app_list/model_pref_updater.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/ui/app_list/model_pref_updater.cc View 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/browser/ui/app_list/model_pref_updater_unittest.cc View 1 chunk +0 lines, -105 lines 0 comments Download
M chrome/test/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 26 (15 generated)
khmel
Hi Steven and Christopher, PTAL Please feel free to ban this CL if you think ...
4 years, 2 months ago (2016-10-18 19:10:22 UTC) #10
stevenjb
lgtm if there are no objections from calamity@. +benwells@ FYI since I'm not sure what ...
4 years, 2 months ago (2016-10-18 20:20:30 UTC) #12
benwells
On 2016/10/18 20:20:30, stevenjb wrote: > lgtm if there are no objections from calamity@. > ...
4 years, 2 months ago (2016-10-18 23:21:37 UTC) #13
calamity
lgtm
4 years, 2 months ago (2016-10-19 04:52:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2430753002/20001
4 years, 2 months ago (2016-10-19 14:41:38 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/285081)
4 years, 2 months ago (2016-10-19 14:52:02 UTC) #18
khmel
Thank you all for review! Hi sky@ Could you please review: c/b/prefs/browser_prefs.cc c/b/sync/test/integration/two_client_app_list_sync_test.cc PTAL
4 years, 2 months ago (2016-10-19 15:55:26 UTC) #20
sky
LGTM
4 years, 2 months ago (2016-10-19 19:28:50 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2430753002/20001
4 years, 2 months ago (2016-10-19 19:35:03 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-19 21:10:59 UTC) #24
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:11:26 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b8997b03c95df27570d0beab45cc42fe1df95c20
Cr-Commit-Position: refs/heads/master@{#426283}

Powered by Google App Engine
This is Rietveld 408576698