Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2430673002: [debugger] remove test for legacy JSON API to return V8's version. (Closed)

Created:
4 years, 2 months ago by Yang
Modified:
4 years, 1 month ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] remove test for legacy JSON API to return V8's version. R=jgruber@chromium.org BUG=v8:5510 Committed: https://crrev.com/61dc1de0f66963414d2a85260a515780d61050bd Cr-Commit-Position: refs/heads/master@{#40432}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -92 lines) Patch
M src/debug/debug.js View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +1 line, -2 lines 0 comments Download
D test/mjsunit/debug-version.js View 1 chunk +0 lines, -90 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Yang
4 years, 2 months ago (2016-10-18 13:29:41 UTC) #1
Yang
On 2016/10/18 13:29:41, Yang wrote: ping
4 years, 2 months ago (2016-10-19 10:35:22 UTC) #2
jgruber
Sorry, missed this one. lgtm
4 years, 2 months ago (2016-10-19 10:38:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2430673002/1
4 years, 2 months ago (2016-10-19 11:43:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 12:35:28 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:06:23 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61dc1de0f66963414d2a85260a515780d61050bd
Cr-Commit-Position: refs/heads/master@{#40432}

Powered by Google App Engine
This is Rietveld 408576698