Removed use of IsRunningOnIOS8OrLater from ui_util and uikit_ui_util

Removed use of IsRunningOnIOS8OrLater from ui_util and uikit_ui_util

BUG=633626
Committed: https://crrev.com/a090419a7c2db425450ba531db9d2c5d6b838868
Cr-Commit-Position: refs/heads/master@{#426260}

[pkl (ping after 24h if needed), 2016-10-18 00:19:06]

pkl@chromium.org changed reviewers:
+ justincohen@chromium.org, marq@chromium.org

[pkl (ping after 24h if needed), 2016-10-18 00:19:06]

Removed pre-iOS8 code.

[marq (ping after 24h), 2016-10-18 10:41:55]

LGTM

Not for this CL, but some of these functions (CurrentScreenWidth(), etc) could
be deprecated since the correct UIKit call is now also just a single line.

[justincohen, 2016-10-18 10:59:21]

lgtm, my comments are all nits to make everything one line

https://codereview.chromium.org/2430463003/diff/1/ios/chrome/browser/ui/ui_ut...
File ios/chrome/browser/ui/ui_util.mm (right):

https://codereview.chromium.org/2430463003/diff/1/ios/chrome/browser/ui/ui_ut...
ios/chrome/browser/ui/ui_util.mm:44: CGSize screenSize = [UIScreen
mainScreen].bounds.size;
return [UIScreen mainScreen].bounds.size.height ?

https://codereview.chromium.org/2430463003/diff/1/ios/chrome/browser/ui/ui_ut...
ios/chrome/browser/ui/ui_util.mm:49: CGSize screenSize = [UIScreen
mainScreen].bounds.size;
return [UIScreen mainScreen].bounds.size.width ?

https://codereview.chromium.org/2430463003/diff/1/ios/chrome/browser/ui/uikit...
File ios/chrome/browser/ui/uikit_ui_util.mm (right):

https://codereview.chromium.org/2430463003/diff/1/ios/chrome/browser/ui/uikit...
ios/chrome/browser/ui/uikit_ui_util.mm:457: CGSize keyboardSize =
[keyboardFrameValue CGRectValue].size;
return [keyboardFrameValue CGRectValue].size.height ?

[pkl (ping after 24h if needed), 2016-10-19 18:47:32]

https://codereview.chromium.org/2430463003/diff/1/ios/chrome/browser/ui/ui_ut...
File ios/chrome/browser/ui/ui_util.mm (right):

https://codereview.chromium.org/2430463003/diff/1/ios/chrome/browser/ui/ui_ut...
ios/chrome/browser/ui/ui_util.mm:44: CGSize screenSize = [UIScreen
mainScreen].bounds.size;
On 2016/10/18 10:59:20, justincohen wrote:
> return [UIScreen mainScreen].bounds.size.height ?

Done.

https://codereview.chromium.org/2430463003/diff/1/ios/chrome/browser/ui/ui_ut...
ios/chrome/browser/ui/ui_util.mm:49: CGSize screenSize = [UIScreen
mainScreen].bounds.size;
On 2016/10/18 10:59:20, justincohen wrote:
> return [UIScreen mainScreen].bounds.size.width ?

Done.

https://codereview.chromium.org/2430463003/diff/1/ios/chrome/browser/ui/uikit...
File ios/chrome/browser/ui/uikit_ui_util.mm (right):

https://codereview.chromium.org/2430463003/diff/1/ios/chrome/browser/ui/uikit...
ios/chrome/browser/ui/uikit_ui_util.mm:457: CGSize keyboardSize =
[keyboardFrameValue CGRectValue].size;
On 2016/10/18 10:59:20, justincohen wrote:
> return [keyboardFrameValue CGRectValue].size.height ?

Done.

[pkl (ping after 24h if needed), 2016-10-19 18:47:38]

The CQ bit was checked by pkl@chromium.org

[pkl (ping after 24h if needed), 2016-10-19 18:47:38]

The patchset sent to the CQ was uploaded after l-g-t-m from marq@chromium.org,
justincohen@chromium.org
Link to the patchset: https://codereview.chromium.org/2430463003/#ps20001
(title: "one line!!!1!")

[commit-bot: I haz the power, 2016-10-19 18:48:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 19:37:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-21 13:10:45]

Description was changed from

==========
Removed use of IsRunningOnIOS8OrLater from ui_util and uikit_ui_util

BUG=633626
==========

to

==========
Removed use of IsRunningOnIOS8OrLater from ui_util and uikit_ui_util

BUG=633626

Committed: https://crrev.com/a090419a7c2db425450ba531db9d2c5d6b838868
Cr-Commit-Position: refs/heads/master@{#426260}
==========

[commit-bot: I haz the power, 2016-10-21 13:10:45]

Patchset 2 (id:??) landed as
https://crrev.com/a090419a7c2db425450ba531db9d2c5d6b838868
Cr-Commit-Position: refs/heads/master@{#426260}