Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 24304004: [XHR] Abort method execution when m_loader->cancel() in internalAbort() caused reentry (Closed)

Created:
7 years, 3 months ago by tyoshino (SeeGerritForStatus)
Modified:
7 years, 3 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[XHR] Abort method execution when m_loader->cancel() in internalAbort() caused reentry Calling cancel() on DocumentThreadableLoader may results in calling window.onload synchronously. If open(), send(), etc. are called on the same XMLHttpRequest object, it'll be hard to resolve conflict of states without losing spec conformance. This CL avoids that by just aborting execution of code for the outer method that calls internalAbort() if it returns false. BUG=292422 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158146

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -12 lines) Patch
M LayoutTests/http/tests/xmlhttprequest/reentrant-cancel-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 6 chunks +29 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tyoshino (SeeGerritForStatus)
7 years, 3 months ago (2013-09-20 14:12:14 UTC) #1
tyoshino (SeeGerritForStatus)
As discussed at this old CL https://codereview.chromium.org/23465030/ made this new one which aborts outer method ...
7 years, 3 months ago (2013-09-20 14:13:30 UTC) #2
Nate Chapin
Ideally in the long term, we'll make events not do crazy, reentrant things. But until ...
7 years, 3 months ago (2013-09-20 19:29:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/24304004/1
7 years, 3 months ago (2013-09-20 20:03:06 UTC) #4
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=7328
7 years, 3 months ago (2013-09-20 20:17:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/24304004/1
7 years, 3 months ago (2013-09-20 20:41:19 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-21 01:35:39 UTC) #7
Message was sent while issue was closed.
Change committed as 158146

Powered by Google App Engine
This is Rietveld 408576698