Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2430383003: Ntp: add illustration for all dismissed state. (Closed)

Created:
4 years, 2 months ago by Michael van Ouwerkerk
Modified:
4 years, 1 month ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ntp: add illustration for all dismissed state. BUG=651058 Committed: https://crrev.com/90f0b761dc39f71ce87477f93e9c33664c307118 Cr-Commit-Position: refs/heads/master@{#426154}

Patch Set 1 #

Messages

Total messages: 13 (6 generated)
Michael van Ouwerkerk
Bernhard, could you take a look please?
4 years, 2 months ago (2016-10-19 10:55:55 UTC) #3
Bernhard Bauer
lgtm
4 years, 2 months ago (2016-10-19 11:45:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2430383003/1
4 years, 2 months ago (2016-10-19 11:46:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 12:05:41 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/90f0b761dc39f71ce87477f93e9c33664c307118 Cr-Commit-Position: refs/heads/master@{#426154}
4 years, 2 months ago (2016-10-21 13:07:09 UTC) #11
agrieve
On 2016/10/21 13:07:09, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 1 month ago (2016-10-25 19:49:33 UTC) #12
Michael van Ouwerkerk
4 years, 1 month ago (2016-10-26 09:03:33 UTC) #13
Message was sent while issue was closed.
On 2016/10/25 19:49:33, agrieve (OOO oct 17-21) wrote:
> On 2016/10/21 13:07:09, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/90f0b761dc39f71ce87477f93e9c33664c307118
> > Cr-Commit-Position: refs/heads/master@{#426154}
> 
> This commit came up on the apk size graph as increasing apk size by ~100kb. 
> 
> It looks like this image doesn't use transparency, so did you consider using
> .webp instead? A quick check shows that it reduced the image size by 50%.

I've filed crbug.com/659522 for this, let's continue the discussion over there.

Powered by Google App Engine
This is Rietveld 408576698