VideoCapture: remove last remnants of IPC

VideoCapture: remove last remnants of IPC

In this CL:
- On Browser: VCHost is not a BrowserMessageFilter nor
a  BrowserAssociatedInterface, and instead works like a
normal service implementation, Create()d on request and
hanging from the render process host.

-On renderer:
 - VideoCaptureMessageFilter, which was specific for
IPC, is removed altogether.
 - VCImpl (the "client"), does not need the IPC, and
instead gets an InterfacePtr to the remote VideoCaptureHost,
and uses it.

All that allows for a few simplifications around like, e.g.
VCImpl doesn't need to keep track of  |clients_pending_on_filter_|
nor of IO thread explicitly (using a ThreadChecker instead),
and also I cleaned up a bit more the unittests.

BUG=651897
Committed: https://crrev.com/049d6417fa6d74291ef6048dd94dfd8f8b571215
Cr-Commit-Position: refs/heads/master@{#426903}

[mcasas, 2016-10-21 02:24:52]

Description was changed from

==========
VideoCapture: remove last remnants of IPC

BUG=651897
==========

to

==========
VideoCapture: remove last remnants of IPC

In this CL:
- On Browser: VCHost is not a BrowserMessageFilter nor 
a  BrowserAssociatedInterface, and instead works like a 
normal service implementation, Create()d on request and 
hanging from the render process host.

-On renderer:
 - VideoCaptureMessageFilter, which was specific for 
IPC, is removed altogether.
 - VCImpl (the "client"), does not need the IPC, and 
instead gets an InterfacePtr to the remote VideoCaptureHost,
and uses it.

All that allows for a few simplifications around like, e.g. 
VCImpl doesn't need to keep track of  |clients_pending_on_filter_| 
nor of IO thread explicitly (using a ThreadChecker instead),
and also I cleaned up a bit more the unittests.

BUG=651897
==========

[mcasas, 2016-10-21 02:34:07]

Patchset #1 (id:1) has been deleted

[mcasas, 2016-10-21 02:47:01]

Patchset #1 (id:20001) has been deleted

[mcasas, 2016-10-21 16:13:21]

mcasas@chromium.org changed reviewers:
+ avi@chromium.org, rockot@chromium.org, tsepez@chromium.org

[mcasas, 2016-10-21 16:13:22]

rockot@ PTAL, particularly inside
video_capture_{host,impl,impl_manager} where the
action happens

avi@ plz RS changes to BUILD.gn (removing files).

tsepez@ please RS removal of video_capture_messages.h, yay!

[Avi (use Gerrit), 2016-10-21 17:24:25]

On 2016/10/21 16:13:22, mcasas wrote:
> rockot@ PTAL, particularly inside
> video_capture_{host,impl,impl_manager} where the
> action happens
> 
> avi@ plz RS changes to BUILD.gn (removing files).
> 
> tsepez@ please RS removal of video_capture_messages.h, yay!

BUILD.gn LGTM

[Ken Rockot(use gerrit already), 2016-10-21 17:29:28]

lgtm

https://codereview.chromium.org/2430313007/diff/40001/content/renderer/media/...
File content/renderer/media/video_capture_impl.cc (right):

https://codereview.chromium.org/2430313007/diff/40001/content/renderer/media/...
content/renderer/media/video_capture_impl.cc:75: if
(RenderThreadImpl::current()) {  // This is null in unit tests.
nit: You don't need a RenderThreadImpl specifically, so IMHO you should just use
ChildThread::Get(). You can probably also just create a MockRenderThread in your
unit tests so ChildThread::Get() is non-null. Your preference.

[Tom Sepez, 2016-10-21 18:13:18]

RS LGTM on deleting messages.

[mcasas, 2016-10-21 19:02:35]

https://codereview.chromium.org/2430313007/diff/40001/content/renderer/media/...
File content/renderer/media/video_capture_impl.cc (right):

https://codereview.chromium.org/2430313007/diff/40001/content/renderer/media/...
content/renderer/media/video_capture_impl.cc:75: if
(RenderThreadImpl::current()) {  // This is null in unit tests.
On 2016/10/21 17:29:27, Ken Rockot wrote:
> nit: You don't need a RenderThreadImpl specifically, so IMHO you should just
use
> ChildThread::Get(). 
Done.

> You can probably also just create a MockRenderThread in your
> unit tests so ChildThread::Get() is non-null. Your preference.

Other unittests do sth similar, avoiding having to mock too
much, since anyway we have |video_capture_host_for_testing_|.

[mcasas, 2016-10-21 19:03:49]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2016-10-21 19:03:49]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org, avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2430313007/#ps60001
(title: "rockot@ comment on using ChildThread")

[commit-bot: I haz the power, 2016-10-21 19:04:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 21:54:10]

Description was changed from

==========
VideoCapture: remove last remnants of IPC

In this CL:
- On Browser: VCHost is not a BrowserMessageFilter nor 
a  BrowserAssociatedInterface, and instead works like a 
normal service implementation, Create()d on request and 
hanging from the render process host.

-On renderer:
 - VideoCaptureMessageFilter, which was specific for 
IPC, is removed altogether.
 - VCImpl (the "client"), does not need the IPC, and 
instead gets an InterfacePtr to the remote VideoCaptureHost,
and uses it.

All that allows for a few simplifications around like, e.g. 
VCImpl doesn't need to keep track of  |clients_pending_on_filter_| 
nor of IO thread explicitly (using a ThreadChecker instead),
and also I cleaned up a bit more the unittests.

BUG=651897
==========

to

==========
VideoCapture: remove last remnants of IPC

In this CL:
- On Browser: VCHost is not a BrowserMessageFilter nor 
a  BrowserAssociatedInterface, and instead works like a 
normal service implementation, Create()d on request and 
hanging from the render process host.

-On renderer:
 - VideoCaptureMessageFilter, which was specific for 
IPC, is removed altogether.
 - VCImpl (the "client"), does not need the IPC, and 
instead gets an InterfacePtr to the remote VideoCaptureHost,
and uses it.

All that allows for a few simplifications around like, e.g. 
VCImpl doesn't need to keep track of  |clients_pending_on_filter_| 
nor of IO thread explicitly (using a ThreadChecker instead),
and also I cleaned up a bit more the unittests.

BUG=651897
==========

[commit-bot: I haz the power, 2016-10-21 21:54:11]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-10-21 22:00:11]

Description was changed from

==========
VideoCapture: remove last remnants of IPC

In this CL:
- On Browser: VCHost is not a BrowserMessageFilter nor 
a  BrowserAssociatedInterface, and instead works like a 
normal service implementation, Create()d on request and 
hanging from the render process host.

-On renderer:
 - VideoCaptureMessageFilter, which was specific for 
IPC, is removed altogether.
 - VCImpl (the "client"), does not need the IPC, and 
instead gets an InterfacePtr to the remote VideoCaptureHost,
and uses it.

All that allows for a few simplifications around like, e.g. 
VCImpl doesn't need to keep track of  |clients_pending_on_filter_| 
nor of IO thread explicitly (using a ThreadChecker instead),
and also I cleaned up a bit more the unittests.

BUG=651897
==========

to

==========
VideoCapture: remove last remnants of IPC

In this CL:
- On Browser: VCHost is not a BrowserMessageFilter nor
a  BrowserAssociatedInterface, and instead works like a
normal service implementation, Create()d on request and
hanging from the render process host.

-On renderer:
 - VideoCaptureMessageFilter, which was specific for
IPC, is removed altogether.
 - VCImpl (the "client"), does not need the IPC, and
instead gets an InterfacePtr to the remote VideoCaptureHost,
and uses it.

All that allows for a few simplifications around like, e.g.
VCImpl doesn't need to keep track of  |clients_pending_on_filter_|
nor of IO thread explicitly (using a ThreadChecker instead),
and also I cleaned up a bit more the unittests.

BUG=651897

Committed: https://crrev.com/049d6417fa6d74291ef6048dd94dfd8f8b571215
Cr-Commit-Position: refs/heads/master@{#426903}
==========

[commit-bot: I haz the power, 2016-10-21 22:00:13]

Patchset 2 (id:??) landed as
https://crrev.com/049d6417fa6d74291ef6048dd94dfd8f8b571215
Cr-Commit-Position: refs/heads/master@{#426903}