third_party/WebKit/Source/web/mac/WebSubstringUtil.mm - Issue 2430253003: Get rid of createVisibleSelection() to take EphemeralRange

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

Issue 2430253003: Get rid of createVisibleSelection() to take EphemeralRange (Closed)

Patch Set: 2016-10-20T14:03:19 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

diff --git a/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm b/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

index fbfb18d3f390393f8a5a09d20655962f2db50dd5..7460f657fa79e51a498db120515ca67b20df9771 100644

--- a/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

+++ b/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

@@ -167,7 +167,8 @@ NSAttributedString* WebSubstringUtil::attributedWordAtPoint(

return nil;

// Expand to word under point.

- VisibleSelection selection = createVisibleSelection(range);

+ VisibleSelection selection = createVisibleSelection(

+ SelectionInDOMTree::Builder().setBaseAndExtent(range).build());

selection.expandUsingGranularity(WordGranularity);

const EphemeralRange wordRange = selection.toNormalizedEphemeralRange();

« no previous file with comments | « third_party/WebKit/Source/web/WebLocalFrameImpl.cpp ('k') | no next file » | no next file with comments »