Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.cpp

Issue 2430253003: Get rid of createVisibleSelection() to take EphemeralRange (Closed)
Patch Set: 2016-10-20T14:03:19 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
index fb3069fe61f76e94f0d4211defb816f5f0074449..566ccf0777a348fdc23370e2e3ba858672e3ee89 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
@@ -112,17 +112,6 @@ VisibleSelection createVisibleSelection(const VisiblePosition& base,
base.affinity(), isDirectional);
}
-VisibleSelection createVisibleSelection(const EphemeralRange& range,
- TextAffinity affinity,
- bool isDirectional) {
- DCHECK(!needsLayoutTreeUpdate(range.startPosition()));
- DCHECK(!needsLayoutTreeUpdate(range.endPosition()));
- SelectionInDOMTree::Builder builder;
- builder.setBaseAndExtent(range).setAffinity(affinity).setIsDirectional(
- isDirectional);
- return createVisibleSelection(builder.build());
-}
-
VisibleSelectionInFlatTree createVisibleSelection(
const SelectionInFlatTree& selection) {
return VisibleSelectionInFlatTree::create(selection);
@@ -833,7 +822,6 @@ void VisibleSelectionTemplate<Strategy>::updateIfNeeded() {
appendTrailingWhitespace();
}
-
template <typename Strategy>
static bool equalSelectionsAlgorithm(
const VisibleSelectionTemplate<Strategy>& selection1,

Powered by Google App Engine
This is Rietveld 408576698